quickstart works only with default 'stack' user

[Rafael Folco]

Quickstart fails when overriding default 'stack' user. You cannot specify a non-root-user for VIRTHOST setup other than the default 'stack'. This is useful for dual setup on the same VIRTHOST using two different users (let's say foo and bar) with their respective isolated environments.

$ bash quickstart.sh --tags all -e ssh_user=fstack -e undercloud_user=fstack -e non_root_user=fstack -e remote_user=fstack 127.0.0.2

TASK [setup/undercloud : Copy instackenv.json to appliance] ******************************************************************************************
task path: /home/foo/.quickstart/tripleo-quickstart/roles/libvirt/setup/undercloud/tasks/main.yml:78
Friday 15 December 2017 12:32:11 -0500 (0:00:00.079) 0:05:00.900 *******
fatal: [127.0.0.2]: FAILED! => {"changed": true, "cmd": ["virt-customize", "-a", "/home/fstack/undercloud.qcow2", "--upload", "/home/fstack/instackenv.json:/home/fstack/instackenv.json", "--run-command", "chown fstack:fstack /home/fstack/instackenv.json"], "delta": "0:00:21.960042", "end": "2017-12-15 12:32:36.025620", "failed": true, "msg": "non-zero return code", "rc": 1, "start": "2017-12-15 12:32:14.065578", "stderr": "virt-customize: error: libguestfs error: upload: \n/home/fstack/instackenv.json: No such file or directory\n\nIf reporting bugs, run virt-customize with debugging enabled and include \nthe complete output:\n\n virt-customize -v -x [...]", "stderr_lines": ["virt-customize: error: libguestfs error: upload: ", "/home/fstack/instackenv.json: No such file or directory", "", "If reporting bugs, run virt-customize with debugging enabled and include ", "the complete output:", "", " virt-customize -v -x [...]"], "stdout": "[ 0.0] Examining the guest ...\n[ 21.9] Setting a random seed\n[ 21.9] Uploading: /home/fstack/instackenv.json to /home/fstack/instackenv.json", "stdout_lines": ["[ 0.0] Examining the guest ...", "[ 21.9] Setting a random seed", "[ 21.9] Uploading: /home/fstack/instackenv.json to /home/fstack/instackenv.json"]}

[wes hayutin (weshayutin)]

                                                                                                                                                      │······························································
[stack@rdo-ci-fx2-02-s5 ~]$ ls /home/ │······························································
stack test1 test2 whayutin │······························································
[stack@rdo-ci-fx2-02-s5 ~]$ oooq launched as test1 and as test2, however vms are launched as stack?

BUG!

[wes hayutin (weshayutin)]

TO-DO
update a ci-centos job to use a non-stack user and add validation to ensure the stack user is not created on the virthost.

[Rafael Folco (rafaelfolco)]

I
Complications:
- cannot use current deployer's user when deploying on localhost (=$VIRTHOST), need to specify a different user as it gets removed and recreated:
    * e.g. if you deploy (run oooq) as 'deployer' user, you have to specify ssh_user and non_root_user as something else like 'user1'
    * This is mainly because of teardown (kills all processes for user and recreate the user) - WAD
- ssh_user and non_root_user are used interchangeably in the code
- {{ working_dir }} is interchangeably used as /home/{{ ssh_user }} or /home/{{ undercloud_user }} for two different purposes across oooq and oooq-e sources:
    * /home/{{ ssh_user }}: deployer user's home dir at $VIRTHOST
    * /home/{{ undercloud_user }}: undercloud user's home at undercloud machine