[newton only] Special treatment of os-net-config can cause issue if /etc/os-net-config/config.json is empty.

[Sofer Athlan-Guyot]

Hi,

originally reported there https://bugzilla.redhat.com/show_bug.cgi?id=1506283

os-net-config crashes when run unconditionally on configuration without net isolation.

The original problem was caught in a repo where [1] wasn't landed yet, so we had that code instead [2]. [1] solves the issues as a side effect (meaning, not really intended) because it skips the special handling of os-net-config during minor update and major upgrade on non-controller which prevents the run of os-net-config on a empty configuration file altogether.

This is kind of a lucky side effect, but still unintended. So best course of action would be to re-add the code in minor update and major upgrade non-controller but with stronger check before running the os-net-config command.

[1] https://github.com/openstack/tripleo-heat-templates/commit/bce61783bc175e98b535c678d90829344dab5c47#diff-002d345b79ce06e07a34abc8da5ade5f

[2] https://github.com/openstack/tripleo-heat-templates/commit/9f8ba2c052e04c1ba8db756a48181a54c9cd8f68#diff-002d345b79ce06e07a34abc8da5ade5fR326

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/516614

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/516614
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=1147e6ced83f4a3103fa21a5f4da1090c256429d
Submitter: Zuul
Branch: stable/newton

commit 1147e6ced83f4a3103fa21a5f4da1090c256429d
Author: Sofer Athlan-Guyot <email address hidden>
Date: Tue Oct 31 11:18:21 2017 +0100

    os-net-config not run when conf is empty and re-introduce exception.

    There may be cases where os-net-config is empty leading to issue when
    we force the run during its special treatment in upgrade/update.

    Piggy back in this review is re-adding the os-net-config special
    handling to update and non-controller. But it’s more robust now it
    won’t run the command unconditionally, it needs:
     - os-net-config to be upgraded
     - /etc/os-net-config/config.json to exist and not be empty.

    Another improvement is that it will prevent any networking cut during
    its run as we are using the –no-activate flag.

    Change-Id: Ie1b88d5cac22fca5b0b325b1dd8c81d65b63acb8
    Closes-Bug: #1728889

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 5.3.5 release.

[Brent Eagles (beagles)]

Can we close this? It appears to be a newton only bug and the patch was merged.