os-net-config not run when conf is empty and re-introduce exception.
There may be cases where os-net-config is empty leading to issue when
we force the run during its special treatment in upgrade/update.
Piggy back in this review is re-adding the os-net-config special
handling to update and non-controller. But it’s more robust now it
won’t run the command unconditionally, it needs:
- os-net-config to be upgraded
- /etc/os-net-config/config.json to exist and not be empty.
Another improvement is that it will prevent any networking cut during
its run as we are using the –no-activate flag.
Reviewed: https:/ /review. openstack. org/516614 /git.openstack. org/cgit/ openstack/ tripleo- heat-templates/ commit/ ?id=1147e6ced83 f4a3103fa21a5f4 da1090c256429d
Committed: https:/
Submitter: Zuul
Branch: stable/newton
commit 1147e6ced83f4a3 103fa21a5f4da10 90c256429d
Author: Sofer Athlan-Guyot <email address hidden>
Date: Tue Oct 31 11:18:21 2017 +0100
os-net-config not run when conf is empty and re-introduce exception.
There may be cases where os-net-config is empty leading to issue when
we force the run during its special treatment in upgrade/update.
Piggy back in this review is re-adding the os-net-config special net-config/ config. json to exist and not be empty.
handling to update and non-controller. But it’s more robust now it
won’t run the command unconditionally, it needs:
- os-net-config to be upgraded
- /etc/os-
Another improvement is that it will prevent any networking cut during
its run as we are using the –no-activate flag.
Change-Id: Ie1b88d5cac22fc a5b0b325b1dd8c8 1d65b63acb8
Closes-Bug: #1728889