bootstrap node index is hard coded again

[Steven Hardy]

I think the switch to containers has reintroduced https://bugs.launchpad.net/tripleo/+bug/1640449 because we now do:

{get_param: [servers, {{primary_role_name}}, '0']}

In a couple of places in common/deploy-steps.j2

This is a regression because we should instead get the first available server, not the one called "0" from the map generated by the resource group.

Previously we fixed this via https://review.openstack.org/#/c/395699/3/overcloud.j2.yaml but I think a different approach may be needed as we get a map not a list inside deploy-steps.j2

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/513449

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/513450

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/513450
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=a460a093c7a8f1cb18a9f955d7fadb4178416f9a
Submitter: Zuul
Branch: master

commit a460a093c7a8f1cb18a9f955d7fadb4178416f9a
Author: Steven Hardy <email address hidden>
Date: Thu Oct 19 18:06:42 2017 +0100

    Select first node as bootstrap node not using name

    This fixes a regression which reintroduced bug #1640449 because
    we hard-code the node index/name instead of sorting the map of servers

    Change-Id: Iaffc66a41edf176dde3b5adf603a9cff6db7aa24
    Closes-Bug: #1724888

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/523822

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/523822
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=ce071f3faea62f1337d80e42f12b201606074d29
Submitter: Zuul
Branch: stable/pike

commit ce071f3faea62f1337d80e42f12b201606074d29
Author: Steven Hardy <email address hidden>
Date: Thu Oct 19 18:06:42 2017 +0100

    Select first node as bootstrap node not using name

    This fixes a regression which reintroduced bug #1640449 because
    we hard-code the node index/name instead of sorting the map of servers

    Conflicts:
     common/deploy-steps.j2

    Change-Id: Iaffc66a41edf176dde3b5adf603a9cff6db7aa24
    Closes-Bug: #1724888
    (cherry picked from commit a460a093c7a8f1cb18a9f955d7fadb4178416f9a)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 8.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 7.0.6 release.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Alex Schultz (<email address hidden>) on branch: master
Review: https://review.openstack.org/513449
Reason: Abandoning this patch per the TripleO Patch Abandonment guidelines (https://specs.openstack.org/openstack/tripleo-specs/specs/policy/patch-abandonment.html). If you wish to have this restored and cannot do so yourself, please reach out via #tripleo on freenode or the OpenStack Dev mailing list.