Cannot remove bootstrap node for any role

Bug #1640449 reported by Steven Hardy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Steven Hardy

Bug Description

Since we now configure the bootstrap node for all roles (not only the controller) we have a problem if you need to remove the "0" node in any role, as we've got a hard-coded value that affects selection of the bootstrap node for all roles:

https://github.com/openstack/tripleo-heat-templates/blob/master/overcloud.j2.yaml#L234

 input_values:
        bootstrap_nodeid: {get_attr: [{{role.name}}, resource.0.hostname]}
        bootstrap_nodeid_ip: {get_attr: [{{role.name}}, resource.0.ip_address]}

We need some way to change this index when replacing node "0", or another way to detect the first node in the group without using the node name (this looks like an index but I think it's referring to the resource name in the resource group, so it should be e.g "1" after this removal, ideally we'd use a list lookup here instead, perhaps that's a possible way to fix this).

First reported here: https://bugzilla.redhat.com/show_bug.cgi?id=1392995

Steven Hardy (shardy)
Changed in tripleo:
status: New → In Progress
importance: Undecided → High
assignee: nobody → Steven Hardy (shardy)
milestone: none → ocata-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.openstack.org/395699

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.openstack.org/395699
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=390292e59e230d575621133cbbfef0aad4bfb9e3
Submitter: Jenkins
Branch: master

commit 390292e59e230d575621133cbbfef0aad4bfb9e3
Author: Steven Hardy <email address hidden>
Date: Wed Nov 9 11:35:03 2016 +0000

    Select bootstrap node by list index not name

    Modify the syntax used to access the ResourceGroup attributes so we
    always select the first node from the group, e.g even if the node
    named "0" in the ResourceGroup nested stack has been removed due to
    the removal policy.

    Change-Id: I8b1c9538976a1518b220187a0034ad41a738d5a6
    Closes-Bug: #1640449

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/396280

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/newton)

Reviewed: https://review.openstack.org/396280
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=035d150ff1cd47d132e414556f338528cf98d223
Submitter: Jenkins
Branch: stable/newton

commit 035d150ff1cd47d132e414556f338528cf98d223
Author: Steven Hardy <email address hidden>
Date: Wed Nov 9 11:35:03 2016 +0000

    Select bootstrap node by list index not name

    Modify the syntax used to access the ResourceGroup attributes so we
    always select the first node from the group, e.g even if the node
    named "0" in the ResourceGroup nested stack has been removed due to
    the removal policy.

    Change-Id: I8b1c9538976a1518b220187a0034ad41a738d5a6
    Closes-Bug: #1640449
    (cherry picked from commit 390292e59e230d575621133cbbfef0aad4bfb9e3)

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 6.0.0.0b1

This issue was fixed in the openstack/tripleo-heat-templates 6.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 5.2.0

This issue was fixed in the openstack/tripleo-heat-templates 5.2.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.