Comment 4 for bug 1696598

Reviewed: https://review.openstack.org/471537
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=dc0b057f6e2fdf17ff84f51e5a5af7897226bf12
Submitter: Jenkins
Branch: master

commit dc0b057f6e2fdf17ff84f51e5a5af7897226bf12
Author: Steve Baker <email address hidden>
Date: Wed Jun 7 09:14:52 2017 +1200

    Make overcloud_containers.yaml template driven

    Currently container based CI jobs are implementing their own logic to
    transform overcloud_containers.yaml to a file that reflects the
    container images and registry required to run their job [1] unless the
    job requires the exact images which the static
    overcloud_containers.yaml provides[2].

    This change adds a template overcloud_containers.yaml.j2 which will
    exist in parallel to overcloud_containers.yaml until all downstream
    users of overcloud_containers.yaml switch to a templated approach.

    This change is the first step to write commands which allow
    overcloud_containers.yaml to be built for a specific enviroment,
    including version based tags and reducing the image list to those
    needed by the deployment.

    The test test_container_images_yaml_in_sync will ensure that any
    changes made to overcloud_containers.yaml won't pass until they're
    made to overcloud_containers.yaml.j2 as well. This will keep them in
    sync until overcloud_containers.yaml is removed.

    [1] https://github.com/rdo-infra/ansible-role-rdo-kolla-build/blob/master/tasks/main.yml#L39-L75
    [2] https://github.com/openstack/tripleo-quickstart-extras/blob/master/roles/overcloud-prep-containers/templates/overcloud-prep-containers.sh.j2#L18

    Change-Id: I4fe18565362f9f308dd9957aeb9bc0f7498590a6
    Partial-Bug: #1696598