Comment 1 for bug 1680006

I confirm, on a newton-> ocata upgrade, I've got the same error. Going on the controller:

os-apply-config --key hiera.datafiles --type raw --key-default empty

-> "bootstrap_node": {"mapped_data": {"bootstrap_nodeid": "overcloud-controller-0", "bootstrap_nodeid_ip": "192.168.24.14"}}, "all_nodes": {"mapped_data": {"heat_api_enabled": "true", "mongodb_network": "internal_api", "gnocchi_api_network": "internal_api", "cinder_volume_enabled": "true", "ca_certs_enabled": "true", "timezone_short_node_names": ["overcloud-controller-0", "overcloud-controller-1", "overcloud-controller-2", "overcloud-novacompute-0", "overcloud-novacompute-1", "overcloud-cephstorage-0"],....

so the check in https://review.openstack.org/#/c/426241/2/heat-config-hiera/install.d/hook-hiera.py fails and then the upgrade fails:

Legacy hieradata from os-apply-config has been detected. Please update all of your interfaces to use the new heat-agents hiera hook before proceeding

This https://github.com/openstack-infra/tripleo-ci/blob/master/scripts/tripleo.sh#L844..L846 has been applied and going on the platform:

[root@overcloud-controller-0 ~]# ls -lrth /usr/libexec/os-apply-config/templates/etc/puppet/hiera.yaml /usr/libexec/os-refresh-config/configure.d/40-hiera-datafiles /etc/puppet/hieradata/*.yaml
ls: cannot access /usr/libexec/os-apply-config/templates/etc/puppet/hiera.yaml: No such file or directory
ls: cannot access /usr/libexec/os-refresh-config/configure.d/40-hiera-datafiles: No such file or directory
ls: cannot access /etc/puppet/hieradata/*.yaml: No such file or directory