tripleo

  1. Bug #1651704
  2. Comment #19

Comment 19 for bug 1651704

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-common (master)

Reviewed: https://review.openstack.org/418966
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=c2fb9b025d727fdbfae27d1f25f58efae1cb7679
Submitter: Jenkins
Branch: master

commit c2fb9b025d727fdbfae27d1f25f58efae1cb7679
Author: Dougal Matthews <email address hidden>
Date: Wed Jan 11 14:21:06 2017 +0000

    Fail the scale workflows when sending a "FAILED" message

    When Mistral workflows execute a second workflow (a sub-workflow
    execution), the parent workflow can't easily determine if sub-workflow
    failed. This is because the failure is communicated via a Zaqar message
    only and when a workflow ends with a successful Zaqar message it appears
    have been successful. This problem surfaces because parent workflows
    should have an "on-error" attribute but it is never called, as the
    workflow doesn't error.

    This change marks the workflow as failed if the message has the status
    "FAILED". Now when a sub-workflow fails, the task that called it should
    have the on-error triggered. Previously it would always go to
    on-success.

    Change-Id: I73c5965627e45b8151f67aaf8025369bf6c870bb
    Related-Bug: #1651704