Comment 16 for bug 1651704

Reviewed: https://review.openstack.org/418964
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=ab946c4a0e6b0bf5bc0b31e93af455af5b1887dc
Submitter: Jenkins
Branch: master

commit ab946c4a0e6b0bf5bc0b31e93af455af5b1887dc
Author: Dougal Matthews <email address hidden>
Date: Wed Jan 11 14:16:50 2017 +0000

    Fail the plan_management workflows when sending a "FAILED" message

    When Mistral workflows execute a second workflow (a sub-workflow
    execution), the parent workflow can't easily determine if sub-workflow
    failed. This is because the failure is communicated via a Zaqar message
    only and when a workflow ends with a successful Zaqar message it appears
    have been successful. This problem surfaces because parent workflows
    should have an "on-error" attribute but it is never called, as the
    workflow doesn't error.

    This change marks the workflow as failed if the message has the status
    "FAILED". Now when a sub-workflow fails, the task that called it should
    have the on-error triggered. Previously it would always go to
    on-success.

    Change-Id: Ie0f1d4e57505e9346ae3f0b25d755f55d73a255a
    Related-Bug: #1651704