Lack of default for NovaPCIPassthrough breaks the UI JSON validation

Bug #1645266 reported by Julie Pichon on 2016-11-28
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Medium
Florian Fuchs

Bug Description

The NovaPCIPassthrough doesn't seem to have a default set, and so fails the UI validation for "valid JSON strings" before the user even tries to modify it.

Steps to reproduce
------------------
1. Click on the pencil besides the Compute role to edit it
2. Services -> OS::TripleO::Services::NovaCompute

Expected result
---------------
3. Every parameter is displayed with no form validation failures

Actual result
-------------
3. NovaPCIPassthrough is shown in red with "Please enter a valid JSON string." It's not possible to save any change until this is resolved.

Additional information
-----------------------
See related bug 1638523

Julie Pichon (jpichon) on 2016-11-28
summary: - No valid default for NovaPCIPassthrough
+ Lack of default for NovaPCIPassthrough breaks the UI JSON validation
Changed in tripleo:
assignee: nobody → Florian Fuchs (flo-fuchs)
Julie Pichon (jpichon) wrote :
tags: removed: tripleo-heat-templates

Fix proposed to branch: master
Review: https://review.openstack.org/403634

Changed in tripleo:
status: Triaged → In Progress
Julie Pichon (jpichon) on 2016-11-28
tags: added: newton-backport-potential
Changed in tripleo:
milestone: none → ocata-2

Reviewed: https://review.openstack.org/403634
Committed: https://git.openstack.org/cgit/openstack/tripleo-ui/commit/?id=537618fed2c393cb1fbc0b52f40951dd66e3373c
Submitter: Jenkins
Branch: master

commit 537618fed2c393cb1fbc0b52f40951dd66e3373c
Author: Florian Fuchs <email address hidden>
Date: Mon Nov 28 12:25:48 2016 +0100

    Relax JSON input validation

    Currently the JSON form input validator only passes if the value is a
    valid JSON string. This doesn't accout for cases where a paramater
    doesn't need to be set. This patch relaxes the validation rule so it
    also allows the value to be an empty string.

    Change-Id: I4d135120ac3041b223986eef8f54c4de24f20379
    Closes-Bug: #1645266

Changed in tripleo:
status: In Progress → Fix Released

Reviewed: https://review.openstack.org/405205
Committed: https://git.openstack.org/cgit/openstack/tripleo-ui/commit/?id=933c1fe214a5f4c516a63ecfb41f8becea0530fd
Submitter: Jenkins
Branch: stable/newton

commit 933c1fe214a5f4c516a63ecfb41f8becea0530fd
Author: Florian Fuchs <email address hidden>
Date: Mon Nov 28 12:25:48 2016 +0100

    Relax JSON input validation

    Currently the JSON form input validator only passes if the value is a
    valid JSON string. This doesn't accout for cases where a paramater
    doesn't need to be set. This patch relaxes the validation rule so it
    also allows the value to be an empty string.

    Change-Id: I4d135120ac3041b223986eef8f54c4de24f20379
    Closes-Bug: #1645266
    (cherry picked from commit 537618fed2c393cb1fbc0b52f40951dd66e3373c)

tags: added: in-stable-newton

This issue was fixed in the openstack/tripleo-ui 2.0.1 release.

This issue was fixed in the openstack/tripleo-ui 1.1.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers