Invalid JSON in parameters breaks deployments/parameters screen
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
tripleo |
Fix Released
|
High
|
Florian Fuchs |
Bug Description
It's not always clear that pure JSON must be used for the parameters. If you make a mistake, the deployment will fail but it will become impossible to modify the parameter again.
Steps to reproduce
------------------
1. Pick an option, e.g. CephStorageConfig
2. Enter something wrong, e.g. the way you'd have made the change for a template: ceph::profile:
'/dev/sdc':
journal: '/dev/sdb'
Expected result
---------------
3. Some kind of warning, the wrong value is not saved in the Mistral environment
Actual result
-------------
3. The value is saved.
4. If you try to deploy, it fails with Failed to run action [action_
5. If you reopen the parameters window, it closes quickly on its own before you can modify it, with the following error: Failed to run action [action_ex_id=None, action_cls='<class 'mistral.
summary: |
- Entering invalid JSON for a parameter causes the UI to stop loading the - configuration screen + Invalid JSON in parameters breaks deployments/parameters screen |
Changed in tripleo: | |
assignee: | nobody → Florian Fuchs (flo-fuchs) |
This is what the parameter looks like in the mistral environment, after saving the wrong parameter:
"CephStorageExt raConfig" : "ceph:: profile: :params: :osds:\ n '/dev/sdc':\n journal: '/dev/sdb'\n '/dev/sdd' :\njournal: '/dev/sdb'"