Changes to role configurations are not viewed in real time

Bug #1642216 reported by Udi Kalifon
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Jiri Tomasek

Bug Description

If you edit some of the roles and click "Save Changes" - you get a confirmation "Parameters Updated" but then if you open the configuration again your changes seem to be gone. It takes about 2 minutes until you can confirm that the change was made.

For example, I edited the "Object Storage" role and in the services tab I selected "OS::TripleO::Services::Ntp" and I added a value for NtpServer. I clicked "Save Changes" and navigated away and back again to the same page. My changes were gone. I tried that again and again until finally one attempt worked. I realised after some experimentation that it takes a long time for the updated parameters to be fetched.

In the browser console you see 2 events: FETCH_PARAMETERS_PENDING and FETCH_PARAMETERS_SUCCESS. It takes too much time to fetch the parameters, and to the user it looks like the changes are not saved.

Tags: ui
Changed in tripleo:
status: New → Confirmed
status: Confirmed → Triaged
importance: Undecided → High
milestone: none → ocata-2
Revision history for this message
Julie Pichon (jpichon) wrote :

From bug 1646483, this also applies to the main deployment parameters. I assume it is the same API call and marked the other one as a duplicate, feel free to un-duplicated if I'm mistaken though.

Jiri Tomasek (jtomasek)
Changed in tripleo:
assignee: nobody → Jiri Tomasek (jtomasek)
Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
Julie Pichon (jpichon) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-ui (master)

Fix proposed to branch: master
Review: https://review.openstack.org/409825

Changed in tripleo:
milestone: ocata-2 → ocata-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-ui (master)

Reviewed: https://review.openstack.org/403422
Committed: https://git.openstack.org/cgit/openstack/tripleo-ui/commit/?id=ada4af3c256d39b3fb1152a33629b986da685efb
Submitter: Jenkins
Branch: master

commit ada4af3c256d39b3fb1152a33629b986da685efb
Author: Jiri Tomasek <email address hidden>
Date: Wed Nov 23 16:29:40 2016 +0100

    Normalize parameters

    This change introduces parameters normalization, when a nested
    resources tree from getParameters arrives, the tree is normalized
    into a flat list of resources and parameters. Parameters are uniquely
    identified by name and resources get an uuid generated.

    Parameter and Services lists are constructed using selectors.

    This change allows to sanely store resource tree in application state,
    make any imaginable selections on a subtree or listing certain
    parameters. In addition, we're able to do optimistic updates on
    parameter values in application state.

    Parameters and Resources are ordered alphabetically, Service names are
    truncated to pure service name rather than using resource type name,
    Internal parameters are filtered.

    A list of warnings about colliding parameter properties currently
    appear during normalization. This is a side effect of a bug
    (https://bugs.launchpad.net/tripleo/+bug/1640243) in tripleo-heat-
    templates

    Partial-Bug: 1642216
    Implements: blueprint deployment-configuration-improvements
    Change-Id: I2d4d78b0abc45718df584f7571feb0c2fb30941b

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/409825
Committed: https://git.openstack.org/cgit/openstack/tripleo-ui/commit/?id=efbdd2683bcd3b0591bdb11e58b26bb8474034f7
Submitter: Jenkins
Branch: master

commit efbdd2683bcd3b0591bdb11e58b26bb8474034f7
Author: Jiri Tomasek <email address hidden>
Date: Mon Dec 12 16:04:52 2016 +0100

    Update app state when parameters get updated

    This change updates the application state with new parameter values
    when they are successfully set in mistral environment

    Closes-Bug: 1642216
    Change-Id: Iebd52ccb216835497da01eb3fd5a093dd02dc3c0

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-ui 3.0.0

This issue was fixed in the openstack/tripleo-ui 3.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-ui 7.0.0

This issue was fixed in the openstack/tripleo-ui 7.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.