Comment 0 for bug 1640436

Revision history for this message
Dougal Matthews (d0ugal) wrote :

We should not require the use of direct action calls. This is confusing for users and difficult to document. Understanding when you should use one and not the other requires understanding far more of the internals than we should expect from a user. This may lead to a number of workflows only calling one action (or one action + zaqar) but that will at least create a consistent interface.

We can't stop advanced users accessing actions directly, and that is okay, so long as they are willing to do this at their own risk.

Here is a case in point from #tripleo.

09:41 <tzumainn> d0ugal, hi! quick question for you - it looks like when you create a custom plan, you also need to run tripleo.templates.process and tripleo.parameters.generate_passwords - do you know if there are any other executions that need to happen?
09:42 <tzumainn> d0ugal, hm, really?
09:42 <d0ugal> tzumainn: because it does those steps.
09:42 <d0ugal> https://github.com/openstack/tripleo-common/blob/master/workbooks/plan_management.yaml#L24
09:42 <d0ugal> tzumainn: https://github.com/openstack/tripleo-common/blob/master/workbooks/plan_management.yaml#L19
09:42 <tzumainn> d0ugal, ah, I'm running the create_plan action, not the workflow
09:42 <jpich> jaosorior: Ok... hm
09:42 <tzumainn> I have erred greatly
09:43 <d0ugal> tzumainn: YES! You are demonstrating why I never wanted people to call actions directly
09:43 <d0ugal> tzumainn: thanks :)
09:44 <d0ugal> tzumainn: so, this is probably something I need to make clearer in the documentation.
09:44 <d0ugal> tzumainn: it is quite hard to explain, because there isn't a clear line and it isn't obvious which actions should be used directly
09:45 <tzumainn> d0ugal, I'm glad my ignorance is helpful in some weird way : )