Reviewed: https://review.openstack.org/375576 Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=9393a3e2a57d293eabe1fcfb702b0cecdf5e60ff Submitter: Jenkins Branch: master
commit 9393a3e2a57d293eabe1fcfb702b0cecdf5e60ff Author: Michele Baldessari <email address hidden> Date: Fri Sep 23 17:31:19 2016 +0200
get_param calls with multiple arguments need brackets around them
This issue was spotted during major upgrade where we had calls like this:
servers: {get_param: servers, Controller}
These get_param calls are hanging indefinitely and make the whole upgrade end in a timeout. We need to put brackets around the get_param function when there are multiple arguments: http://docs.openstack.org/developer/heat/template_guide/hot_spec.html#get-param
This is already done in most of the tree, and the few places where this was not happening were parts not under CI. After this change the following grep returns only one false positive:
grep -ir get_param: |grep -v -- '\[' |grep ','
Change-Id: I65b23bb44f37b93e017dd15a5212939ffac76614 Closes-Bug: #1626628
Reviewed: https:/ /review. openstack. org/375576 /git.openstack. org/cgit/ openstack/ tripleo- heat-templates/ commit/ ?id=9393a3e2a57 d293eabe1fcfb70 2b0cecdf5e60ff
Committed: https:/
Submitter: Jenkins
Branch: master
commit 9393a3e2a57d293 eabe1fcfb702b0c ecdf5e60ff
Author: Michele Baldessari <email address hidden>
Date: Fri Sep 23 17:31:19 2016 +0200
get_param calls with multiple arguments need brackets around them
This issue was spotted during major upgrade where we had calls like
this:
servers: {get_param: servers, Controller}
These get_param calls are hanging indefinitely and make the whole docs.openstack. org/developer/ heat/template_ guide/hot_ spec.html# get-param
upgrade end in a timeout. We need to put brackets around the get_param
function when there are multiple arguments:
http://
This is already done in most of the tree, and the few places where this
was not happening were parts not under CI. After this change the
following grep returns only one false positive:
grep -ir get_param: |grep -v -- '\[' |grep ','
Change-Id: I65b23bb44f37b9 3e017dd15a52129 39ffac76614
Closes-Bug: #1626628