Comment 0 for bug 1593736

tl;dr do we need to update puppet-tripleo and release openstack-puppet-modules because '::tripleo::selinux' ? The bug @ https://bugs.launchpad.net/tripleo/+bug/1593182 also needs o-p-m update so this may get fixed if that happens there.

During upgrade of a stable/mitaka environment to latest newton (delorean repos), and after applying a fix for bug https://bugs.launchpad.net/tripleo/+bug/1593182, the "openstack undercloud upgrade" fails with:

    2016-06-17 11:09:51 - Error: Could not find class ::tripleo::selinux for instack on node instack
    2016-06-17 11:09:51 - Error: Could not find class ::tripleo::selinux for instack on node instack
    + rc=1
    + set -e
    + echo 'puppet apply exited with exit code 1'
    puppet apply exited with exit code 1
    + '[' 1 '!=' 2 -a 1 '!=' 0 ']'
    + exit 1
    [2016-06-17 11:09:51,792] (os-refresh-config) [ERROR] during configure phase. [Command '['dib-run- parts', '/usr/libexec/os-refresh-config/configure.d']' returned non-zero exit status 1]

    [2016-06-17 11:09:51,792] (os-refresh-config) [ERROR] Aborting...
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/usr/lib/python2.7/site-packages/instack_undercloud/undercloud.py", line 1039, in install
        _run_orc(instack_env)
    File "/usr/lib/python2.7/site-packages/instack_undercloud/undercloud.py", line 917, in _run_orc
      _run_live_command(args, instack_env, 'os-refresh-config')
      File "/usr/lib/python2.7/site-packages/instack_undercloud/undercloud.py", line 450, in _run_live_command
        raise RuntimeError('%s failed. See log for details.' % name)
RuntimeError: os-refresh-config failed. See log for details.
    Command 'instack-install-undercloud' returned non-zero exit status 1

some combination of grep and git blame told me that '::tripleo::selinux' was introduced by

"Add tripleo::selinux " https://review.openstack.org/#/c/309408/ If214005df733d41c2fa4e197df247d8a14baaa14 puppet-tripleo

so I _think_ we need an update of puppet-tripleo in the openstack-puppet-modules and a new release of o-p-m? Note that https://bugs.launchpad.net/tripleo/+bug/1593182 also requires an update of openstack-puppet-modules (but for a puppet-nova fix).

This env has

    Version : 8.1.1
    Release : 0.20160609150428.ab63b38.el7.centos
    Size : 14 M
    Repo : installed
    From repo : delorean
    Summary : Puppet modules used to deploy OpenStack

For now I worked around this by manually patching tripleo in the openstack-puppet-modules

    https://review.openstack.org/changes/309408/revisions/8e533aaf447022c62865130f2ffc88690f06aef1/patch?zip

    sudo su
    yum install unzip
    # backup the templates incase:
    cp -r /usr/share/openstack-puppet/modules/tripleo /usr/share/openstack-puppet/modules/tripleo.BACKUP
    pushd /usr/share/openstack-puppet/modules/tripleo

    # https://review.openstack.org/#/c/298685/ Set UpdateIdentifier for upgrade converge, to prevent services down
    curl -o "patch1.diff.zip" https://review.openstack.org/changes/309408/revisions/8e533aaf447022c62865130f2ffc88690f06aef1/patch?zip
    unzip patch1.diff.zip
    patch -p1 < 8e533aaf.diff

    exit # the sudo su

and with that the openstack undercloud upgrade got further (but hitting another issue, will file another bug for that \o/ ... )