stable/mitaka to newton undercloud upgrade fails with various errors related to o-p-m packaging
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
tripleo |
Fix Released
|
Medium
|
Marios Andreou |
Bug Description
[UPDATE 05 July 2016]:
Updating to reflect that this will track a number of errors that were seen here and that were all related to the openstack-
this.bug, was previously for tracking "Error: Could not find class ::tripleo::selinux for instack on node instack"
https:/
https:/
https:/
https:/
Those bugs will all be closed as duplicated pointing here.
Original bug description, for the 'selinux' issue follows.
*******
tl;dr do we need to update puppet-tripleo and release openstack-
During upgrade of a stable/mitaka environment to latest newton (delorean repos), and after applying a fix for bug https:/
2016-06-17 11:09:51 - Error: Could not find class ::tripleo::selinux for instack on node instack
2016-06-17 11:09:51 - Error: Could not find class ::tripleo::selinux for instack on node instack
+ rc=1
+ set -e
+ echo 'puppet apply exited with exit code 1'
puppet apply exited with exit code 1
+ '[' 1 '!=' 2 -a 1 '!=' 0 ']'
+ exit 1
[2016-06-17 11:09:51,792] (os-refresh-config) [ERROR] during configure phase. [Command '['dib-run- parts', '/usr/libexec/
[2016-06-17 11:09:51,792] (os-refresh-config) [ERROR] Aborting...
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/usr/lib/
File "/usr/lib/
_
File "/usr/lib/
raise RuntimeError('%s failed. See log for details.' % name)
RuntimeError: os-refresh-config failed. See log for details.
Command 'instack-
some combination of grep and git blame told me that '::tripleo:
"Add tripleo::selinux " https:/
so I _think_ we need an update of puppet-tripleo in the openstack-
This env has
Version : 8.1.1
Release : 0.2016060915042
Size : 14 M
Repo : installed
From repo : delorean
Summary : Puppet modules used to deploy OpenStack
For now I worked around this by manually patching tripleo in the openstack-
sudo su
yum install unzip
# backup the templates incase:
cp -r /usr/share/
pushd /usr/share/
# Add tripleo::selinux https:/
curl -o "patch1.diff.zip" https:/
unzip patch1.diff.zip
patch -p1 < 8e533aaf.diff
popd
exit # the sudo su
and with that the openstack undercloud upgrade got further (but hitting another issue, will file another bug for that \o/ ... )
description: | updated |
description: | updated |
Changed in tripleo: | |
milestone: | none → newton-2 |
summary: |
- stable/mitaka to newton undercloud upgrade fails with 'Could not find - class ::tripleo::selinux' + table/mitaka to newton undercloud upgrade fails with various errors + related to o-p-m packaging |
summary: |
- table/mitaka to newton undercloud upgrade fails with various errors + stable/mitaka to newton undercloud upgrade fails with various errors related to o-p-m packaging |
description: | updated |
Changed in tripleo: | |
milestone: | newton-2 → newton-3 |
I am having trouble understanding how rdo openstack- puppet- modules is pulling in the puppet-tripleo module (more below) so a summary here I can point at for help; I have openstack- puppet- modules- 8.1.1-0. 20160609150428. ab63b38. el7.centos. noarch after the yum update with latest repos, but still don't have the selinux class in /usr/share/ openstack- puppet/ modules/ tripleo/ manifests/ . That is, the change at https:/ /review. openstack. org/#/c/ 309408/ isn't included in that package build it seems/afaics.
To reiterate, I deployed stable/mitaka. Then to upgrade, I disable stable/mitaka, enable latest repos using tripleo.sh, stop all services (thanks bnemec) like https:/ /review. openstack. org/#/c/ 331804 and then yum update:
sudo systemctl stop openstack-*
sudo systemctl stop neutron-*
# Depending on when the base image was created, the pinned delorean repo may repos.d/ delorean* github. com/openstack- infra/tripleo- ci.git ~/tripleo-ci ;fi;
./tripleo- ci/scripts/ tripleo. sh --repo-setup
# actually be older, which causes yum to ignore its metadata.
sudo rm -f /etc/yum.
sudo yum clean all && sudo yum clean metadata && sudo yum clean dbcache && sudo yum makecache
if ! [[ -d ~/tripleo-ci ]]; then git clone http://
nice -n -10 sudo yum update -y
openstack undercloud upgrade
2016-06-22 10:48:01 - Error: Could not find class ::tripleo::selinux for instack on node instack
2016-06-22 10:48:01 - Error: Could not find class ::tripleo::selinux for instack on node instack
I assume the openstack- puppet- modules package I get from the latest delorean repos (from ./tripleo- ci/scripts/ tripleo. sh --repo-setup) is made via https:/ /github. com/rdo- packages/ openstack- puppet- modules- distgit
The version I have is openstack- puppet- modules- 8.1.1-0. 20160609150428. ab63b38. el7.centos. noarch - I can confirm that there is no selinux.pp in the installed code:
total 96
drwxr-xr-x. 2 root root 4096 Jun 14 13:15 cluster
-rw-r--r--. 1 root root 1559 Jun 9 15:05 fencing.pp
drwxr-xr-x. 2 root root 4096 Jun 14 13:15 firewall
-rw-r--r--. 1 root root 2418 Jun 9 15:05 firewall.pp
-rw-r--r--. 1 root root 688 Jun 9 15:05 init.pp
-rw-r--r--. 1 root root 51401 Jun 9 15:05 loadbalancer.pp
drwxr-xr-x. 3 root root 4096 Jun 14 13:15 network
-rw-r--r--. 1 root root 1632 Jun 9 15:05 noop.pp
-rw-r--r--. 1 root root 2477 Jun 9 15:05 packages.pp
drwxr-xr-x. 4 root root 4096 Jun 14 13:15 profile
-rw-r--r--. 1 root root 1133 Jun 9 15:05 redis_notificat
drwxr-xr-x. 2 root root 4096 Jun 14 13:15 ssl
My question is, what version of https:/ /github. com/openstack/ puppet- tripleo is pulled into that openstack- puppet- modules package and how is that governed? Do we need to add a version constraint to https:/ /github. com/rdo- packages/ openstack- puppet- modules- distgit/ blob/9d3bcf2d35 c4b816fb310ec74 c2aa1ad008ba767 /openstack- puppet- modules. spec#L74 ?
One other thing I noticed - does it matter that there is a difference b...