Fix distinguishing between stack-create and stack-update
Previously we tried to use UpdateIdentifier for two different things:
tell whether to perform package update, and also to tell whether the
top-level stack is being created or updated (which was incorrect and
resulted in bug 1567384, and an attempt to work around that bug resulted
in bug 1567385).
We cannot use Heat's "action" conditionals in some cases, because they
refer to the direct parent stack, which can yield undesirable results
when introducing new nested stacks or temporarily no-opping something
and then adding it back (in both these cases, "action" would be
considered "CREATE", even though the top-level stack is in "UPDATE").
So tripleoclient passes a new parameter StackAction to tell whether the
top-level stack is being created or updated, and we make use of
that. (It seems there's no better way of getting this info from within
the nested Heat stacks.)
Reviewed: https:/ /review. openstack. org/312420 /git.openstack. org/cgit/ openstack/ tripleo- heat-templates/ commit/ ?id=fda107a3f1e a4fd63a2b358177 2432f079c09e3c
Committed: https:/
Submitter: Jenkins
Branch: stable/mitaka
commit fda107a3f1ea4fd 63a2b3581772432 f079c09e3c
Author: Jiri Stransky <email address hidden>
Date: Mon Apr 11 12:38:00 2016 +0200
Fix distinguishing between stack-create and stack-update
Previously we tried to use UpdateIdentifier for two different things:
tell whether to perform package update, and also to tell whether the
top-level stack is being created or updated (which was incorrect and
resulted in bug 1567384, and an attempt to work around that bug resulted
in bug 1567385).
We cannot use Heat's "action" conditionals in some cases, because they
refer to the direct parent stack, which can yield undesirable results
when introducing new nested stacks or temporarily no-opping something
and then adding it back (in both these cases, "action" would be
considered "CREATE", even though the top-level stack is in "UPDATE").
So tripleoclient passes a new parameter StackAction to tell whether the
top-level stack is being created or updated, and we make use of
that. (It seems there's no better way of getting this info from within
the nested Heat stacks.)
Change-Id: Ie14ddbff15e7ed 21aaa3fcdacf36e 0040f912382 df34d8babf0e4c6 505041f5311 f258f0fe1a4e733 1df67c1c85)
Depends-On: I9dc3b4cd8a6a71
Closes-Bug: #1567384
Related-Bug: #1567385
(cherry picked from commit aa0bd9eb1b16581