commit bbb38534866c96e7688618b41449cae07871f3a2
Author: Dan Prince <email address hidden>
Date: Sun Feb 28 20:19:49 2016 -0500
Use set -e for validation-scripts/all-nodes.sh
Update this script to use 'set -e' for all commands except
the ping checks themselves which we allow to fail so we
can give enhanced output.
This resolves an issue where some commands could fail and cause
an undetectable error (the scripted exits with success) thus causing
a case where Heat won't detect any network errors at all. This
was recently the case with git commit 45be848 where we switched
to use python -c 'import ipaddr' which wasn't even installed as a
library on our overcloud nodes, thus causing all network validations
to silently fail.
Reviewed: https:/ /review. openstack. org/285857 /git.openstack. org/cgit/ openstack/ tripleo- heat-templates/ commit/ ?id=bbb38534866 c96e7688618b414 49cae07871f3a2
Committed: https:/
Submitter: Jenkins
Branch: master
commit bbb38534866c96e 7688618b41449ca e07871f3a2
Author: Dan Prince <email address hidden>
Date: Sun Feb 28 20:19:49 2016 -0500
Use set -e for validation- scripts/ all-nodes. sh
Update this script to use 'set -e' for all commands except
the ping checks themselves which we allow to fail so we
can give enhanced output.
This resolves an issue where some commands could fail and cause
an undetectable error (the scripted exits with success) thus causing
a case where Heat won't detect any network errors at all. This
was recently the case with git commit 45be848 where we switched
to use python -c 'import ipaddr' which wasn't even installed as a
library on our overcloud nodes, thus causing all network validations
to silently fail.
Change-Id: I40ed6a537136e8 66357cc0d9304e9 05afdd28522 9202e5e5cdcac9b 50f46b3e6c8
Depends-On: Ia617f44b4673b8
Related-bug: #1551048