collect-flavors-and-verify-profiles validation fails when Overcloud{{role.name}}Flavor is not explicitly defined in templates

[Takashi Kajinami]

Description
===========
collect-flavors-and-verify-profiles validation fails with the following message,

"msg": "Role 'Controller' is in use, but has no flavor assigned\nRole 'Compute' is in use, but has no flavor assigned\nRole..."

It seems that this validation requires that Overcloud{{role.name}}Flavor parameter is explicitly set.
However this flavor parameter is not required in tripleo-heat-templates, and the default flavor (baremetal or FlavorDefault defined in roles_data.yaml) is used if the parameter is not defined in deployment templates.
So we should implement the same logic to pick up the default value automatically, instead of requiring users add these parameters just for validation.

Steps to reproduce
==================
* Deploy overcloud without Overcloud{{role.name}}Flavor parameter set
* Run collect-flavors-and-verify-profiles validation

Expected result
===============
The validation fails with the error "Role 'Controller' is in use, but has no flavor assigned"

Actual result
=============
The validation doesn't fail with the above message

Environment
===========
This issue was initially reported in https://bugzilla.redhat.com/show_bug.cgi?id=1891389 and observed in stable/train

Logs & Configs
==============

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/759607

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/759607
Committed: https://git.openstack.org/cgit/openstack/tripleo-validations/commit/?id=c0698312ad491bb89320c74448d9ff0a1213c6bc
Submitter: Zuul
Branch: master

commit c0698312ad491bb89320c74448d9ff0a1213c6bc
Author: Takashi Kajinami <email address hidden>
Date: Mon Oct 26 13:56:16 2020 +0900

    Use the default flavor name when flavor parameter is not defined

    This patch ensures that the default flavor is used when the flavor
    parameter (Overcloud{{role.name}}Flavor) is not explicitly defined
    in deployment templates and plan, to emulate the behavior in tht
    to pick up the defalt flavor to deploy baremetal instances.

    Closes-Bug: #1901472
    Change-Id: I6970a7fc294305d4fe6ad43b9c2e29090a1ecb37

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/761623

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/761625

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/761625
Committed: https://git.openstack.org/cgit/openstack/tripleo-validations/commit/?id=b300bd2c58a14babf6868714f91b3410b868acc2
Submitter: Zuul
Branch: stable/ussuri

commit b300bd2c58a14babf6868714f91b3410b868acc2
Author: Takashi Kajinami <email address hidden>
Date: Mon Oct 26 13:56:16 2020 +0900

    Use the default flavor name when flavor parameter is not defined

    This patch ensures that the default flavor is used when the flavor
    parameter (Overcloud{{role.name}}Flavor) is not explicitly defined
    in deployment templates and plan, to emulate the behavior in tht
    to pick up the defalt flavor to deploy baremetal instances.

    Closes-Bug: #1901472
    Change-Id: I6970a7fc294305d4fe6ad43b9c2e29090a1ecb37
    (cherry picked from commit c0698312ad491bb89320c74448d9ff0a1213c6bc)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/761623
Committed: https://git.openstack.org/cgit/openstack/tripleo-validations/commit/?id=d949f0eb515ad646a3059fb4bd382b490464c4fa
Submitter: Zuul
Branch: stable/train

commit d949f0eb515ad646a3059fb4bd382b490464c4fa
Author: Takashi Kajinami <email address hidden>
Date: Mon Oct 26 13:56:16 2020 +0900

    Use the default flavor name when flavor parameter is not defined

    This patch ensures that the default flavor is used when the flavor
    parameter (Overcloud{{role.name}}Flavor) is not explicitly defined
    in deployment templates and plan, to emulate the behavior in tht
    to pick up the defalt flavor to deploy baremetal instances.

    Closes-Bug: #1901472
    Change-Id: I6970a7fc294305d4fe6ad43b9c2e29090a1ecb37
    (cherry picked from commit c0698312ad491bb89320c74448d9ff0a1213c6bc)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-validations 12.3.3 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-validations 11.4.0 release.