2020-10-26 04:52:38 |
Takashi Kajinami |
summary |
collect-flavors-and-verify-profiles validation fails with the following message, "msg": "Role 'Controller' is in use, but has no flavor assigned\nRole 'Compute' is in use, but has no flavor assigned\nRole..." It seems that this validation requires that Overcloud{{role.name}}Flavor parameter is explicitly set. However this flavor parameter is not required in tripleo-heat-templates, and the default flavor (baremetal or FlavorDefault defined in roles_data.yaml) is used if the parameter is not defined in deployment templates. So we should implement the same logic to pick up the default value automatically, instead of requiring users add these parameters just for validation. |
collect-flavors-and-verify-profiles validation fails when Overcloud{{role.name}}Flavor is not explicitly defined in templates |
|
2020-10-26 04:54:59 |
Takashi Kajinami |
description |
collect-flavors-and-verify-profiles validation fails with the following message,
"msg": "Role 'Controller' is in use, but has no flavor assigned\nRole 'Compute' is in use, but has no flavor assigned\nRole..."
It seems that this validation requires that Overcloud{{role.name}}Flavor parameter is explicitly set.
However this flavor parameter is not required in tripleo-heat-templates, and the default flavor (baremetal or FlavorDefault defined in roles_data.yaml) is used if the parameter is not defined in deployment templates.
So we should implement the same logic to pick up the default value automatically, instead of requiring users add these parameters just for validation. |
Description
===========
collect-flavors-and-verify-profiles validation fails with the following message,
"msg": "Role 'Controller' is in use, but has no flavor assigned\nRole 'Compute' is in use, but has no flavor assigned\nRole..."
It seems that this validation requires that Overcloud{{role.name}}Flavor parameter is explicitly set.
However this flavor parameter is not required in tripleo-heat-templates, and the default flavor (baremetal or FlavorDefault defined in roles_data.yaml) is used if the parameter is not defined in deployment templates.
So we should implement the same logic to pick up the default value automatically, instead of requiring users add these parameters just for validation.
Steps to reproduce
==================
* Deploy overcloud without Overcloud{{role.name}}Flavor parameter set
* Run collect-flavors-and-verify-profiles validation
Expected result
===============
The validation fails with the error "Role 'Controller' is in use, but has no flavor assigned"
Actual result
=============
The validation doesn't fail with the above message
Environment
===========
This issue was initially reported in https://bugzilla.redhat.com/show_bug.cgi?id=1891389 and observed in stable/train
Logs & Configs
============== |
|