Comment 3 for bug 142358

Revision history for this message
Toby Dickenson (htrd) wrote :

> Is there some specific problem or unusual behavior you are seeing? Or
> are you just nervous about log messages you haven't seen before?

I am fairly sure that my objects have never experienced this call sequence before this recent change. Does that qualify as 'unusal behaviour'?

My objects are not seeing any *bad* behaviour, but only thanks to defensive programming. My log messages come from branches that I never expected to be taken.

> The tpc_begin(), abort(), tpc_abort() sequence looks normal to

Really? Having the abort() in the middle *looks* wrong to me, in the same way that mismatched parentheses *look* wrong.

(As I said before, I am not entirely confident that my expectations are correct here)