Comment 1 for bug 1451618

Bug in code that was clearing the trailing part of the varchar column - was not distinguishing between 2 bytes length vs. 4 byte length. As per Anoop this code is a leftover and is not needed:

"
yes, this looks like a pbm in clearUnusedVarchar. It is not handling lengths correctly
...

This method is only called during bulk move of varchar when we clear unused
trailing bytes. We don’t really need to do that since we always add length in
front of returned data.
.....

No, all cases should be fine.
Callers should not rely on null padded trailing bytes and should only
pick up as many bytes as the prefix length indicates.

That clearing up of trailing bytes is probably a leftover from old days."

For the following test case "ZZ" was missing before the fix.

SQL>create table t38(c1 varchar(32768) not null);
--- SQL operation complete.
SQL>insert into t38 values('abcdefZZ');
--- 1 row(s) inserted.
SQL>select * from t38;

C1
--------------------------------------------------------------------------------
------------------------------------------------
abcdefZZ
===

Breakpoint 3, ExpTupleDesc::clearUnusedVarchar (dataPtr=0x2883770 "\b",
    len=32772, isNullable=0) at ../exp/exp_tuple_desc.h:913
913 NABoolean isNull = FALSE;
(gdb) n
914 if (isNullable)
(gdb)
921 if (!isNull)
(gdb)
923 Int32 actualLen = getVarLength(dataPtr, ExpTupleDesc::SQLARK_EXPLO
DED_FORMAT);
(gdb)
924 dataPtr += (sizeof(short) + actualLen);
(gdb) p actualLen
$9 = 8
(gdb) n
925 len -= (sizeof(short) + actualLen);
(gdb) p dataPtr
$10 = 0x288377a "ZZ"
(gdb) n
927 if (len)
(gdb) p len
$11 = 32762
(gdb) n
929 memset(dataPtr, 0, len);
(gdb)

==============