Comment 5 for bug 549647

Revision history for this message
Rodja (trappe) wrote :

The U1 bug is fixed and I've succsessfully synced all my notes by using the newly havy refactored code. The next step will be to implement uploading changed Notes to the remote server and hence implement basic editing of notes.

Until now I've come up with three questions regarding the Tomboy sync code:

1. Aquiring Lock
Is a lock aquired by connecting to the remote server and making shure we get a current-sync-guid as it seems to be done in Tomboy (WebSyncServer.cs:62)? How is the unlock done?

2. Resetting Client
In SyncManager.cs:425 happens check to make sure the current-sync-guid is the same as the one known by the client. Otherwise the client is resetted. The comment indicates this is needed to make sure local notes are not deleted when the server is wiped/reinitialized. Will the server change it's guid when wiped? Also I wonder why a reset is going to help in such a situation.

3. Title Conflicts
What is the purpose of the title conflict resolving code (SyncManager.cs:450)? It seems to search for notes which
 * have changed/created on the server since last update
 * are not found via UUID on the local side, but
 * have the same title as a local Note but different content
If I unserstand correctly, this can only happen when two clients seperately create a note with same title. Must the title be unique within Tomboy? Otherwise I do not understand why this title conflict code is needed at all...