Comment 3 for bug 549643

Revision history for this message
Benoit Garret (benoit.garret) wrote :

Sorry for the delay. I played a bit with your code, it looks quite nice and unobstrusive (which is good!).

I have a few nitpick though, from a user perspective as I haven't looked at the code:
 * Launching two sync operation in a short period produces strange results. This isn't your fault but I should have put a lock to prevent the user from doing the mistake.
 * When on a slow connection (ie. GPRS), the icon rotates so slowly that it is easy to believe nothing is happening. I can't really see how far along the sync operation has advanced, so wouldn't it be better to rotate the icon constantly?
 * Nothing really happens when syncing from the SD Card, the icon moves a little bit at the very beginning, then nothing. It doesn't change colors like it does with the webservice.

You may already be aware of these but I don't know if you're planning to do further work on this, so I'm throwing them here just in case.

And again nice work, I'm really looking forward to merge your work.