Comment 5 for bug 1448783

Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

Hi Kavoura,

Thanks for taking the time to check that! I cannot reproduce your comment #4. When I have location data disabled, and then enable it, I refresh the scope and now sunrise and sunset times seem to always show for me. Please make more comments here if you continue to not see sunrise & sunset times after enabling location data and refreshing the scope.

Interesting idea of saving the sunrise/sunset times. The main point of this information is to show the user the sunset and sunrise times today, in their current location, whatever it happens to be. While we could theoretically get all such times for, say, the next 365 days for the current location, we would then run the risk of displaying the wrong times if the user has moved. So yes, we could then check if the user has moved, and if so, get that information and save it too, but now we we need to get and save a year's worth of data every time the user moves. That's starting to get complicated :). So on balance, I think that if the user does not want to use location awareness, they don't get sunset/sunrise times.