[SRU] Update to 1.5.2-1

[Sebastian Geiger]

[Impact]

This is a bug fix release that includes:
- Translation updates
- A fix for matching of URLs. Without this fix the URL matching feature is broken and cannot be used.
- A fix for an issue that can cause the close-tab confirmation dialog to reappear when the dialog is canceled.
- A fix for an issue that could cause the tilda window to appear behind panels in fullscreen mode.
- A fix for a leak in the signal handling code that caused the "switch-tab" signal handler to be re-added every time a tab was opened.
- An update to the URL matching regex that adds the '@' character. Without this fix URLs that contain an '@' character are not correctly matched in tilda and are cut-off before the '@' character.

NEWS / Changelog
- https://github.com/lanoxx/tilda/commit/370a5da668f94a4dcd130936ad5dbc3a9285bad9

All changes are documented in the upstream milestones:
- 1.5.2 https://github.com/lanoxx/tilda/milestone/8?closed=1
- 1.5.1 https://github.com/lanoxx/tilda/milestone/7?closed=1

[Test Case]

- URL matching:
1. Print a URL in the terminal, such as with `echo https://google.com`
2. Hover over the URL with the mouse. Without this patch the URL will not be turned into a link and cannot be clicked.

- Context Menu Reappearing:
1. Open context menu
2. Close context menu
3. Open a new tab
4. Close the new tab -> Confirmation dialog should open (if not this can be configured in the settings).
5. Click cancel -> Without this fix confirmation dialog will re-appear.

- Fullscreen tilda window appears behind panel:
1. Open tilda window
2. Switch to fullscreen (via F11 by default)
3. Toggle tilda window to hidden and show again.
4. Observe that without this fix, the tilda window can sometimes re-appear behind panels.

- Signal handling leak:
1. There is no test case for this issue. Without the fix signal handles are continued to be registered when a new tab is opened and are not correctly cleaned up when a tab is closed causing a linear increase in callbacks when a user switches tabs.

- Handle '@' character
1. Output a URL which contains an '@' character, without this patch the URL will be cut-off before the '@' character, but we cannot observe this because URL matching is broken in 1.5.0. With this fix we can observe that the URL is correctly matched.

[Regression Potential]

Regression potential overall is very low. All changes fix known bugs and no new features are added.

The regression potential for URL matching is minimal. Without this change the URL matching feature is broken. Even if this added a regression to the URL matching code this is still better than having no URL matching at all. The change for the '@' character matching could in the worse case affect matching of other URLs that.

The regression potential for the context menu change is minimal, we only add a new signal handler to ensure that the menu is correctly detached from the window when the context menu is closed.

The regression potential for the switch-tab signal handler change is minimal, the code itself has not changed, the signal is just registered to a different object to avoid registering it multiple times.

[Other Info]

This is my first SRU bug, please let me know if anything is missing.

[Sebastian Geiger (lanoxx)]

This debdiff contains the changes for the update to the latest version.

[Brian Murray (brian-murray)]

We, the SRU team, prefer that there is an individual bug for issue being fixed as this allows the bugs to be verified independently rather than us having to check and make sure that each fix is properly verified in one bug report. I realize this creates more work for you the uploader but could you create separate bugs for each issue? Thanks in advance.

[Sebastian Geiger (lanoxx)]

@Brian Murray, thanks for the response. I have documented each change and the corresponding fix in the upstream issue tracker on Github. They are linked to the two milestones 1.5.1 and 1.5.2:

https://github.com/lanoxx/tilda/milestone/7?closed=1
https://github.com/lanoxx/tilda/milestone/8?closed=1

Here is a more detailed overview of the issues including links to each bug report. Is that enough of do I need to open bug reports for each of these on Launchpad?

== Milestone 1.5.2 ==

Tilda 1.5.1 was tagged but is missing Changelog and version bump
https://github.com/lanoxx/tilda/issues/418

tilda emits a VTE runtime warning about missing MULTILINE flag
https://github.com/lanoxx/tilda/issues/422

== Milestone 1.5.1 ==

The switch-page callback is registered multiple times
https://github.com/lanoxx/tilda/issues/421

Close tab confirmation dialog can reappear if canceled
https://github.com/lanoxx/tilda/issues/420

Fullscreen tilda window can appear behind tilda windows
https://github.com/lanoxx/tilda/issues/419

Url-parsing cuts on at-sign "@"
https://github.com/lanoxx/tilda/issues/404

URL Parsing broken since VTE update to 0.60
https://github.com/lanoxx/tilda/issues/406

[Sebastian Geiger (lanoxx)]

I have opened a Launchpad bug for each upstream bug:

Launchpad bug for upstream bug 406: URL Parsing broken since VTE update to 0.60
https://bugs.launchpad.net/ubuntu/+source/tilda/+bug/1878473

Launchpad bug for upstream bug 404: Url-parsing cuts on at-sign "@"
https://bugs.launchpad.net/ubuntu/+source/tilda/+bug/1878474

Launchpad bug for upstream bug 419: Fullscreen tilda window can appear behind panels
https://bugs.launchpad.net/ubuntu/+source/tilda/+bug/1878475

Launchpad bug for upstream bug 420: Close tab confirmation dialog can reappear if canceled
https://bugs.launchpad.net/ubuntu/+source/tilda/+bug/1878476

Launchpad bug for upstream bug 421: The switch-page callback is registered multiple times
https://bugs.launchpad.net/ubuntu/+source/tilda/+bug/1878478

I think there is no need to open a corresponding Launchpad bug for upstream issues 418 and 422 since they concern issues introduced during the 1.5.1 release which does not have a corresponding package in Ubuntu. This bug is about upgrading from 1.5.0-1.1 directly to 1.5.2.

[Brian Murray (brian-murray)]

Hello Sebastian, or anyone else affected,

Accepted tilda into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/tilda/1.5.2-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Sebastian Geiger (lanoxx)]

I have tested the new version from proposed and it works as expected. The bugs are indeed solved and I did not notice any regressions.

[Chris Halse Rogers (raof)]

The verification of the Stable Release Update for tilda has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Chris Halse Rogers (raof)]

Hi there! We generally prefer for testers to list the actual package version they've checked (not just that it was installed from -proposed) in order to make sure we're *really* releasing the version that was *actually* tested.

In future it's nice to add the output of `apt policy $PACKAGE`, just so we can make doubly sure that we're really releasing the package as-tested ☺. Thanks!

[Launchpad Janitor (janitor)]

This bug was fixed in the package tilda - 1.5.2-0ubuntu1

---------------
tilda (1.5.2-0ubuntu1) focal; urgency=medium

  * Packaged new upstream version (LP: #1877758).
    - Fixes URL parsing with VTE 0.60 (LP: #1878473).
    - Fixes handling of @ sign in URLs (LP: #1878474).
    - Fixes fullscreen windows appearing behind panels (LP: #1878475).
    - Fixes reappearing of close tab dialog (LP: #1878476).
    - Fixes multiple registration of switch-page signal (LP: #1878478).
  * Note that 1.5.1 was skipped due to an issue in the release process.

 -- Sebastian Geiger <email address hidden> Thu, 14 May 2020 13:27:34 +0200