Tilda 1.5.0-1.1: The switch-page callback is registered multiple times

[Sebastian Geiger]

[Impact]

Signal handlers for the "switch-page" signal are continuously being registered when a new tab is opened and are not correctly cleaned up when a tab is closed causing a linear increase in invoked callbacks when a user switches tabs.

Affects Version: 1.5.0-1.1
Fixed Version: 1.5.2-1

The fix is already in Debian unstable and also in Ubuntu Groovy but requires an SRU upload for Focal.

Relevant upstream bug:
https://github.com/lanoxx/tilda/issues/421

[Test Case]

1. This can only be observed in the debug mode when the invocation of the signal handler callback is logged to the console. In debug mode users would see the "tilda_terminal_switch_page_cb" message to be printed N times for N tabs that have been opened (for the life time of the process including for tabs that have already been closed).

Expected result: the switch-page callback is invoked exactly one when the user switches between one tab and another one.

The fix is part of tilda 1.5.1, see upstream milestone for 1.5.1 which tracks the corresponding issue #406:
https://github.com/lanoxx/tilda/milestone/7?closed=1

[Regression Potential]

The regression potential for the switch-page signal handler change is minimal, the code itself has not changed, the signal is just registered to a different object to avoid registering it multiple times.

[Brian Murray (brian-murray)]

Hello Sebastian, or anyone else affected,

Accepted tilda into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/tilda/1.5.2-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Sebastian Geiger (lanoxx)]

I have tested the new version from proposed and I am not seeing any regressions.

[Chris Halse Rogers (raof)]

The verification of the Stable Release Update for tilda has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package tilda - 1.5.2-0ubuntu1

---------------
tilda (1.5.2-0ubuntu1) focal; urgency=medium

  * Packaged new upstream version (LP: #1877758).
    - Fixes URL parsing with VTE 0.60 (LP: #1878473).
    - Fixes handling of @ sign in URLs (LP: #1878474).
    - Fixes fullscreen windows appearing behind panels (LP: #1878475).
    - Fixes reappearing of close tab dialog (LP: #1878476).
    - Fixes multiple registration of switch-page signal (LP: #1878478).
  * Note that 1.5.1 was skipped due to an issue in the release process.

 -- Sebastian Geiger <email address hidden> Thu, 14 May 2020 13:27:34 +0200