Comment 37 for bug 849624

Revision history for this message
In , Giermann (giermann) wrote :

(In reply to comment #32)
> [12:52pm] Fallen: bienvenu_: I guess that could work. I wonder why the others
> didn't come up with that...

Mhh, I can't tell... Maybe this is, because this function has not been overridden on the time of this bug reporting (one year ago).

> [12:53pm] Fallen: ctalbert: any other implications? Do you think bienvenu's
> suggestion will work as expected?
> [12:53pm] ctalbert: Fallen: None that I know of. That sounds like a good
> solution.

Well, I did not investigate further, but started some tests. For some reason these functions seem to be called only on startup and by the notification for new mails. I tested with Lighting 0.5 to override these and simply do nothing, when in calendar mode - which worked and I was still able to select the folder by clicking the folder in the folder pane.

Of course, this has to be changed for current Lightning versions, where the mail/calendar modes were introduced. To override these functions was explicitly wanted in bug 386636 - so we would need an extra decision for calendar mode on startup:
1. Simply ignore only the first SelectFolder()
2. Igrore every SelectFolder() and only override SelectMessage()
3. Ignore SelectFolder() and SelectMessage(), when started with '-calendar' until the user switches the manually to mail mode once

> [12:54pm] ctalbert: We just need to make sure that -calendar gets to us in our
> code, and then take it from there.

I also had problems with this in the past... I would appreciate any help in controlling the message window through an CommandLineHandle, because it does not exist this early. Or do I have to open the window myself and use 'PreventDefault'?