Comment 11 for bug 849624

Comment on attachment 274582
Enable 'about:calendar' and 'about:calendar-month' etc. for starting TB with Lightning-View

Thanks for your patch. It looks really good. I have a couple of mozilla style nits
that I have addressed below. We keep everything less than 80 chars on a line where
it doesn't hurt readability. That's so that diffs look decent in bonsai and
bugzilla.

>+ // display Calendar, when started with 'about:calendar' or 'about:calendar-[VIEW]'
Break this comment into two lines so that each line is less than 80 chars ^^

>+ if ( (window.arguments.length > 0) && window.arguments[0].substr(0, 14) == "about:calendar" ) {
Same with this if ^^ like so:
>+ if ( (window.arguments.length > 0) &&
>+ window.arguments[0].substr(0, 14) == "about:calendar" ) {

>+ var reqView = window.arguments[0].substr(15);
>+ // check, whether requested view exists
No need for comma in this statement ^

>+ setTimeout("showCalendarView('"+reqView+"');", 0);
I have tested this with a bunch of parameters, and I like the effect. However,
I think we need to do just a little more. If you try this with a current nightly,
you'll notice that you get the calendar pane, but the left "folderpane" area
is still the mail "folderpane" and not the calendar left pane. Likewise,
the toolbar is still the mail toolbar and not the calendar toolbar. I think this
means that you just need to add some extra calls to this function, but I think you
should check with mickey or Fallen on IRC about what you need to call in order
to fully switch us into the view.

I am eagerly awaiting the next version of the patch. But, I sadly have to r- this
because of the left pane and toolbar issues.