Here too, no need for the rv, just |return IsReplyEnabled();| and so on
Forgot to mention it earlier, but some doxygen documentation for the new methods would be nice. Something along the lines of
/**
* Get the folder type of the currently selected folder
* @return the folder type, or null if we don't have a selected folder
*/
(From update of attachment 382384) base/content/ mail3PaneWindow Commands. js b/mail/ base/content/ mail3PaneWindow Commands. js base/content/ mail3PaneWindow Commands. js base/content/ mail3PaneWindow Commands. js command, whichText); command, whichText + "AccessKey"); Messages( ) > 0) getCommandStatu s(nsMsgViewComm andType. cmdRequiringMsg Body, enabled, checkStatus);
>diff --git a/mail/
>--- a/mail/
>+++ b/mail/
>@@ -327,15 +327,25 @@
> goSetMenuValue(
> goSetAccessKey(
> }
>+ let rv = false;
> if (GetNumSelected
> {
> if (gDBView)
> {
> gDBView.
>- return enabled.value;
>+ rv = enabled.value;
> }
While you're here, please combine this to one if statement, and then return early if (!enabled.value)
> } ed(); led();
>- return false;
>+ if (rv)
>+ {
>+ if (command == "cmd_reply" || command == "button_reply")
>+ rv = IsReplyEnabled();
>+ else if (command == "cmd_replyall" || command == "button_replyall")
>+ rv = IsReplyAllEnabl
>+ else if (command == "cmd_replylist" || command == "button_replylist")
>+ rv = IsReplyListEnab
>+ }
>+ return rv;
Here too, no need for the rv, just |return IsReplyEnabled();| and so on
Forgot to mention it earlier, but some doxygen documentation for the new methods would be nice. Something along the lines of
/**
* Get the folder type of the currently selected folder
* @return the folder type, or null if we don't have a selected folder
*/
r=mkmelin with those