Comment 73 for bug 411358

Revision history for this message
In , Karlt (karlt) wrote :

Comment on attachment 681454
workaround for old gconf

>+ /* This check is to avoid bug #541130 when old version of gnomevfs (2.16 tested)
>+ is installed then error window pops up if scheme is containing '+' character.
>+ Let's pretend these kind of schemes are not supported by gnomevfs. */

Are you sure gnomevfs is involved in gconf_client_get_* calls?
Can you point me at the GConf code that uses GnomeVFS, please?

> GError *err = nullptr;
> gchar *command = gconf_client_get_string(mClient, key.get(), &err);
> if (!err && command) {
> key.Replace(key.Length() - 7, 7, NS_LITERAL_CSTRING("enabled"));

Can you explain, please, why a dialog would be shown when there is a GError parameter passed to the gconf_client_get_* functions?

(Removing review request for now until we understand what is happening.)