testr test filters fail to apply under python3

Bug #1317607 reported by Clark Boylan on 2014-05-08
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Testrepository
Critical
Clark Boylan

Bug Description

testr test filters work great under python2 but not python3. This happens because the filtration relies on python2 behavior of map() and fails under python3 map(). The resulting behavior is only the first test has the filters applied to it and all other tests are ignored.

I am whipping up a patch right now and will attach it to this bug when I am happy with it.

Changed in testrepository:
status: New → Confirmed
Clark Boylan (cboylan) wrote :

This patch fixes the bug, updates the NEWS file with a description of the fix, and adds a test that explicitly checks for mutliple results returning from the test filter (which would've caught this problem under python3).

I have tested locally in a python2.7 and python3.3 virtualenv and tests are look happy.

Alex Gaynor (alex-gaynor) wrote :

Patch looks correct to me (I don't know enough to verify that the tests are correct though :-)).

Changed in testrepository:
status: Confirmed → Fix Committed
importance: Undecided → Critical
assignee: nobody → Clark Boylan (cboylan)
milestone: none → next
Changed in testrepository:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers