terminator.desktop is not localized.

[fujiwara]

Currently a few languages are localized in terminator.desktop but not all.
I'd like to i18n terminator.desktop.

I'm attaching the patch.

[Chris Jones (cmsj)]

I'm not particularly familiar with internationalising desktop files, but this looks pretty reasonable, thanks!

[Chris Jones (cmsj)]

hmm, on further inspection I'm less clear about how this works - will the Build step automagically insert all of the known translations into the .desktop?

[fujiwara (takao-fujiwara)]

Yes, intltool can merge all .po files and the .desktop.in file and generate the .desktop file during the build.

% patch -p1 < foo.diff
% cd po
% intltool-update -p
% intltool-update -r
% vi foo.po
% cd ..
% python setup.py build

This patch needs intltool.
So the current translations of the .desktop file need to be moved into each .po file.
This is a used in GTK programming normally.

[Chris Jones (cmsj)]

Thanks for the feedback. I'm un-milestoning this from 0.12 because I would like more time to test it and I want to get 0.12 out in the next few days, but we will include this feature in 0.13!

[Chris Jones (cmsj)]

I've applied the patch and updated our genpot.sh script to extract strings from data/terminator.desktop.in, but it doesn't seem to be doing it, so the .desktop strings aren't showing in our .pot, so they're not going to be translatable.
The current code in trunk has your patch applied.

[fujiwara (takao-fujiwara)]

Thanks for your integration.

I could not find the strings in ja.po:
https://translations.launchpad.net/terminator/trunk/+pots/terminator/ja/+translate

Probably you need to update .pot file.

% cd terminator/po
% intltool-update -m
% cat POTFILES.in missing | sort >> POTFILES.in
% intltool-update -p

The genpot.sh invokes xgettext only and intltool-update could be the super set of the genpot.sh.

[Chris Jones (cmsj)]

fujiwara: I'm entirely happy to modify genpot.sh to use intltool-update instead of xgettext - is it sane for me to call it with -g and -o so it goes to the right file and knows about its domain?
I'm also curious if this will break all of the existing translations, since the paths will change (e.g. at the moment the .pot lists filenames relative to the top level, but intltool-update has to be run inside po/, so the paths all start with "../")

[Chris Jones (cmsj)]

I've just pushed up some new changes to trunk which will include a missing file in POTFILES.in and use intltool-update in genpot.sh, so I think we should be sorted now. Please let me know if there are any mistakes!

[fujiwara (takao-fujiwara)]

Thanks for your integration.
I'd like to see all *.po files are updated the new strings in http://translations.launchpad.net so that I can start to translate .po files.

I think your solution of -g and -o is nice at the moment.
intltool checks GETTEXT_PACKAGE value in configure.in for the domain name but I think Terminator doesn't need the file.

Regarding to the path issue "../", probably I think it's no impact with .po.
However if you mind it, probably you may remve the path:
% sed -e "s|^#: ../|#: |g" terminator.pot > terminator.pot.$$
% mv terminator.pot.$$ terminator.pot