Crash for undefined self.prelayout_windows

Bug #1702369 reported by Bryce Harrington
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Terminator
Fix Released
Undecided
Bryce Harrington

Bug Description

With current git of terminator:

  File "/usr/local/bin/terminator", line 126, in <module>
    TERMINATOR.layout_done()
  File "/usr/local/lib/python2.7/dist-packages/terminatorlib/terminator.py", line 395, in layout_done
    if window and window not in self.prelayout_windows:
TypeError: argument of type 'NoneType' is not iterable

After changing terminator.py as follows, it starts up without crashing:

        # Build list of new windows using prelayout list
        new_win_list = []
        for window in self.windows:
            if self.prelayout_windows and window not in self.prelayout_windows:
                new_win_list.append(window)

Revision history for this message
Bryce Harrington (bryce) wrote :

This seems to work for me.

Revision history for this message
Bryce Harrington (bryce) wrote :

Fixed in rev 1833:

revno: 1833
committer: bryce <email address hidden>
branch nick: terminator
timestamp: Mon 2020-03-16 18:15:31 -0700
message:
  Fix crash when there are no predefined windows

      Traceback (most recent call last):
        File "/usr/bin/terminator", line 126, in <module>
        TERMINATOR.layout_done()
        File "/usr/share/terminator/terminatorlib/terminator.py", line 395, in layout_done
        if window not in self.prelayout_windows:
      TypeError: argument of type 'NoneType' is not iterable

  fixes: https://bugs.launchpad.net/terminator/+bug/1702369

Changed in terminator:
assignee: nobody → Bryce Harrington (bryce)
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.