Comment 56 for bug 1599453

Revision history for this message
Braden Kelley (redbmk) wrote :

I'm not really sure what's going on either. I've mostly been running directly from the branch using ./terminator and I keep seeing the white background.

I was planning to take a screencast of the whole thing but it seems to only allow for 30 seconds, which is longer than it takes to download the code on this connection. Anyway, I have the terminal output below of me getting a fresh copy of terminator, installing the patch, then running terminator. I took a screencast of just the part where I opened it so you can see what it looks like.

bmk@namaste ~/code
$ ps -ef | grep term
bmk 21424 1 1 00:39 tty2 00:00:00 /usr/lib/gnome-terminal/gnome-terminal-server
bmk 21870 21565 0 00:39 pts/0 00:00:00 grep --color=auto term

bmk@namaste ~/code
$ bzr branch lp:terminator
Branched 1682 revisions.

bmk@namaste ~/code
$ cd terminator

bmk@namaste ~/code/terminator
$ wget https://launchpadlibrarian.net/297774530/check_vte_colors.diff
--2016-12-13 00:41:04-- https://launchpadlibrarian.net/297774530/check_vte_colors.diff
Resolving launchpadlibrarian.net (launchpadlibrarian.net)... 91.189.89.228, 91.189.89.229
Connecting to launchpadlibrarian.net (launchpadlibrarian.net)|91.189.89.228|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 1552 (1.5K) [text/plain]
Saving to: ‘check_vte_colors.diff’

check_vte_colors.diff 100%[===========================================================================================>] 1.52K --.-KB/s in 0.02s

2016-12-13 00:41:05 (78.6 KB/s) - ‘check_vte_colors.diff’ saved [1552/1552]

bmk@namaste ~/code/terminator
$ patch -p0 < check_vte_colors.diff
patching file terminatorlib/terminal.py
patching file terminatorlib/terminator.py

bmk@namaste ~/code/terminator
$ bzr diff
=== modified file 'terminatorlib/terminal.py'
--- terminatorlib/terminal.py 2016-12-11 04:46:02 +0000
+++ terminatorlib/terminal.py 2016-12-12 22:41:12 +0000
@@ -671,6 +671,10 @@
         if self.config['use_theme_colors']:
             self.fgcolor_active = self.vte.get_style_context().get_color(Gtk.StateType.NORMAL) # VERIFY FOR GTK3: do these really take the theme colors?
             self.bgcolor = self.vte.get_style_context().get_background_color(Gtk.StateType.NORMAL)
+ bgcolor = "#{0:02x}{1:02x}{2:02x}".format(int(self.bgcolor.red * 255),
+ int(self.bgcolor.green * 255),
+ int(self.bgcolor.blue * 255))
+ print "During terminal reconfigure: %s" % (bgcolor)
         else:
             self.fgcolor_active = Gdk.RGBA()
             self.fgcolor_active.parse(self.config['foreground_color'])

=== modified file 'terminatorlib/terminator.py'
--- terminatorlib/terminator.py 2016-12-12 11:27:56 +0000
+++ terminatorlib/terminator.py 2016-12-12 22:41:12 +0000
@@ -441,6 +441,7 @@
                 bgcolor = "#{0:02x}{1:02x}{2:02x}".format(int(bgcolor.red * 255),
                                                           int(bgcolor.green * 255),
                                                           int(bgcolor.blue * 255))
+ print "During terminator reconfigure: %s" % (bgcolor)
                 tmp_win.remove(tmp_vte)
                 del(tmp_vte)
                 del(tmp_win)

bmk@namaste ~/code/terminator
$ ./terminator
During terminator reconfigure: #ffffff
During terminal reconfigure: #ffffff
During terminator reconfigure: #ffffff
During terminal reconfigure: #ffffff