Comment 77 for bug 1030562

Revision history for this message
Stephen Boddy (stephen-j-boddy) wrote :

Most patch review is about applying it, and double checking it has the intended effect with no obvious regressions, possibly with some personal touches sprinkled in, and then finally committing. Then there is a (usually quick) port to the other branch. Providing I can reproduce and test cases are clear, this is pretty quick and smooth. The only time I might ask for help with this is if I'm unable to reproduce, such as some of Egmont's where he is on a newer GTK3 version, or broadcast/input/composed keys which is a bit of a mine field or weird and wonderful corner cases.

I'd say updating the rpm spec file is really useful, as your expertise here is in short supply :-) I suggest you break it out as a task/bug, then if you or I have any queries we can discuss there. (Things like handling install of the still to be integrated html manual, because that was a bit messy for debian.) Just from a brief glance, the install of the manual is missing, and the dependencies are almost certainly out of date.

If you still have time/energy then look for bugs without patches that look like they should be fixed before a release, and have a go at coming up with a fix.