Concurrency parameter in account-generator command is accepting as negative and zero value

[Manik Bindlish]

Ubuntu 16.04
Openstack/Stein

Concurrency parameter in account-generator command is accepting as negative and zero value.

stack@control:~/tempest$ tempest account-generator -r 0 accounts.yaml

or

stack@control:~/tempest$ tempest account-generator -r -1 accounts.yaml

Command is accepting the wrong value 0 or -1 and resulting in blank account.yaml file.

So there should be error during entering of wrong value.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/630128

[Doug Schveninger (ds6901)]

getting close i update ps to fix typo to get it going

[Doug Schveninger (ds6901)]

let me know if you are going to update the parent commit. If not I can address the review

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/733127

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/733127
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=58b0538670097c762880f384749ac007f7fd01c8
Submitter: Zuul
Branch: master

commit 58b0538670097c762880f384749ac007f7fd01c8
Author: Lukas Piwowarski <email address hidden>
Date: Wed Jun 3 12:28:53 2020 +0000

    Fix the argument check for account-generator

    Concurrency parameter for account-generator command was accepting
    negative values and zero.

    This patch makes sure that when the account-generator is passed
    a negative value or zero, it ends with an error.

    Closes-Bug: #1811349
    Partially-Implements: blueprint tempest-cli-unit-test-coverage
    Change-Id: I4d7de89b2ad3ee91d113da3746fe393d8cce2aa2

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tempest 25.0.1 release.

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Martin Kopec <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/tempest/+/630128
Reason: The associated bug is marked as fixed - https://bugs.launchpad.net/tempest/+bug/1811349, therefore I'm gonna abandon this, in case this is still relevant, feel free to restore.