Comment 5 for bug 1708147

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-fwaas-dashboard (master)

Reviewed: https://review.openstack.org/489977
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas-dashboard/commit/?id=d1e5dd423ce781eaed371b274e21d1b4b5fef558
Submitter: Jenkins
Branch: master

commit d1e5dd423ce781eaed371b274e21d1b4b5fef558
Author: YAMAMOTO Takashi <email address hidden>
Date: Wed Aug 2 20:18:58 2017 +0900

    tox_install: Don't leave IFS set

    When running "tox -e docs" in my environment, git clone fails with
    "Too many arguments." It seems ":" in "https://" is affected by IFS.

    1. In tox_install.sh, IFS is set to ":". It affects the current
      execution environment and can have undesirable side effects later.
      It's safer to restore it. (This commit fixes this.)

    2. Otoh, the particular symptom above seems like a bug in a version
      of bash I happen to have.

      bash-3.2$ bash --version
      GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin14)
      Copyright (C) 2007 Free Software Foundation, Inc.
      bash-3.2$ IFS=:
      bash-3.2$ echo a:b
      a:b
      bash-3.2$ echo a:b$x
      a b
      bash-3.2$

    Closes-Bug: #1708147
    Change-Id: I897367bf873c02bbf16162c9b6e2fb5b63ad3e3a