dashboard: tox -e docs "too many arguments"

[YAMAMOTO Takashi]

when running "tox -e docs" in my environment, git clone fails with too "Too many arguments."

1. in tox_install.sh, IFS is set to ":". it affects the current execution environment and can have undesirable side effects later. it's safer to restore it.

2. otoh, the particular symptom above seems like a bug in a version of bash i happen to have.

  bash-3.2$ IFS=:
  bash-3.2$ echo a:b
  a:b
  bash-3.2$ echo a:b$x
  a b
  bash-3.2$

[YAMAMOTO Takashi (yamamoto)]

https://review.openstack.org/#/c/489976/

[YAMAMOTO Takashi (yamamoto)]

https://review.openstack.org/#/c/489977/

[YAMAMOTO Takashi (yamamoto)]

https://review.openstack.org/#/c/489978/

[Antonio Ojea (aojea)]

Mac OSX uses bash 3.2 by default, that may be the reason why is not happening more often this issue, only Mac users are affected.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/489977
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas-dashboard/commit/?id=d1e5dd423ce781eaed371b274e21d1b4b5fef558
Submitter: Jenkins
Branch: master

commit d1e5dd423ce781eaed371b274e21d1b4b5fef558
Author: YAMAMOTO Takashi <email address hidden>
Date: Wed Aug 2 20:18:58 2017 +0900

    tox_install: Don't leave IFS set

    When running "tox -e docs" in my environment, git clone fails with
    "Too many arguments." It seems ":" in "https://" is affected by IFS.

    1. In tox_install.sh, IFS is set to ":". It affects the current
      execution environment and can have undesirable side effects later.
      It's safer to restore it. (This commit fixes this.)

    2. Otoh, the particular symptom above seems like a bug in a version
      of bash I happen to have.

      bash-3.2$ bash --version
      GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin14)
      Copyright (C) 2007 Free Software Foundation, Inc.
      bash-3.2$ IFS=:
      bash-3.2$ echo a:b
      a:b
      bash-3.2$ echo a:b$x
      a b
      bash-3.2$

    Closes-Bug: #1708147
    Change-Id: I897367bf873c02bbf16162c9b6e2fb5b63ad3e3a

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/489978
Committed: https://git.openstack.org/cgit/openstack/neutron-vpnaas-dashboard/commit/?id=4f780b1c5f0c78fdd0b6300849b1341d4236da7b
Submitter: Jenkins
Branch: master

commit 4f780b1c5f0c78fdd0b6300849b1341d4236da7b
Author: YAMAMOTO Takashi <email address hidden>
Date: Wed Aug 2 20:20:30 2017 +0900

    tox_install: Don't leave IFS set

    When running "tox -e docs" in my environment, git clone fails with
    "Too many arguments." It seems ":" in "https://" is affected by IFS.

    1. In tox_install.sh, IFS is set to ":". It affects the current
      execution environment and can have undesirable side effects later.
      It's safer to restore it. (This commit fixes this.)

    2. Otoh, the particular symptom above seems like a bug in a version
      of bash I happen to have.

      bash-3.2$ bash --version
      GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin14)
      Copyright (C) 2007 Free Software Foundation, Inc.
      bash-3.2$ IFS=:
      bash-3.2$ echo a:b
      a:b
      bash-3.2$ echo a:b$x
      a b
      bash-3.2$

    Closes-Bug: #1708147
    Change-Id: Icf515dc2ee7e2da2a6b0efa6c6e8cbb45c78da46

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron-fwaas-dashboard 1.0.0 release.

[YAMAMOTO Takashi (yamamoto)]

https://review.openstack.org/#/c/489976/