Horizon and tacker client allow one to create VNFD's with same name

[vishwanath jayaraman]

Currently, horizon and tackerclient allows to create VNFD's with the same.
It would be a better experience to check for duplicate names and throw an error like most of the other openstack components such as firewall do.

[Bob Haddleton (bob-haddleton)]

I had a discussion about this issue with Sriram on IRC last week and it seems this is the expected behavior in OpenStack. Duplicate names are allowed for resources, and IDs should be used to access specific resources. I can't say I agree with the policy in all cases, but if that's what the community consensus is I'll go along.

[Bob Haddleton (bob-haddleton)]

My apologies - I meant Sridhar, not Sriram.

[vishwanath jayaraman (vishwanathj)]

Would be curious to know the background or rationale for allowing duplicate names for resources. See attached screenshot for confusion caused when network resource created with duplicate names are chosen during instance creation.

[Sridhar Ramaswamy (srics-r)]

@Vish - this is the general operating pattern for most openstack resources. Obviously none of us in this subgroup can comment on the origin of that pattern! Quick google search shows even Nova punted this as a non-issue,

https://bugs.launchpad.net/horizon/+bug/1275934

[Sridhar Ramaswamy (srics-r)]

Moving it back to our backlog based on the discussion in,

https://review.openstack.org/#/c/203371

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/329759

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/329759
Committed: https://git.openstack.org/cgit/openstack/tacker/commit/?id=f9729fb388b06672bdd05388d1d8047fb45abfaa
Submitter: Jenkins
Branch: master

commit f9729fb388b06672bdd05388d1d8047fb45abfaa
Author: Sripriya <email address hidden>
Date: Tue Jun 14 21:36:54 2016 -0700

    Introduce uniqueness constraint on resource names

    Resource names are handled to be unique per tenant for all 3
    resources vnfd, vnf and vim.

    Also existing duplicate names are updated to name-<12char. uudid>
    based on resource id's last 12 char. to handle the uniqueness
    constraint on 'name' column for all 3 resources.

    Change-Id: I689d7219db67892b855e1dc5c3698f9e1a67b408
    Closes-Bug: #1475047
    Closes-Bug: #1474993

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tacker 0.5.0 release.