Disallow duplicate instance names within the same project

[Vahid Hashemian]

Currently it is possible to pick duplicate names for instances in the same project.
Ideally, with the score of a project, users should not be able to create instances with existing names, or update instance names to a name that already exists. When "Instance Count" is greater than 1 in Launch Instance screen the instance id is appended to the entered name to guarantee uniqueness. This uniqueness should apply to manual creation too.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/71649

[Tihomir Trifonov (ttrifonov)]

Why having duplicate instance names is a problem? This seems more like a configurable restriction than a general rule here.

[Matthias Runge (mrunge)]

If instances are the problem, why it's not the case for (public) images, or is it? IMHO yes, and I think that should be solved in a comparable way.

[Julie Pichon (jpichon)]

I'm a bit concerned about the proliferation of settings, especially when we're trying to enforce restrictions that the clients don't have. Having different behaviours when using the CLI tools and the web dashboard tends to lead to confusion and bug reports (e.g. bug 1285138).

[Vahid Hashemian (vahidhashemian)]

Hi Julie, thank you for your feedback.
Your concern, as expressed by some other reviewers in the patch reviews, was the reason this restriction became a configurable setting so that Horizon follows the CLI tool by default, and adds this extra restrction only if users choose to.
I'm not sure if that is enough to address your concern. Thanks.

[Lin Hua Cheng (lin-hua-cheng)]

I prefer not to have this added to horizon, I share the same concerns as Julie.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Julie Pichon (<email address hidden>) on branch: master
Review: https://review.openstack.org/71649
Reason: Consensus in the review comments indicates Horizon is not the right place for this. Marking the change as Abandoned to remove it from the list of open reviews. Please continue the discussion in the bug report if needed.

[Julie Pichon (jpichon)]

Based on the consensus in the bug and review comments, marking as Invalid. This can be revisited if the option is added at the API level or the concerns expressed (cf. particularly the review comments) can be reasonably addressed.