Create VNF, VNFD and VIM from Horizon and tackerclient allows to create resosurces with duplicate names

Bug #1474993 reported by vishwanath jayaraman
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tacker
Fix Released
Low
Sripriya

Bug Description

As can be seen from the attached screenshot, multiple VNFs can be created with duplicate names.
This is being allowed from both Horizon UI and tackerclient.

Todo:

-> Enforce Unique key constraint in DB schema on names column for VNF, VNFD and VIM resources.

-> Ensure existing db model is not broken with the unique constraint failing with Integrity Error for duplicate row entries on 'name' column

Revision history for this message
vishwanath jayaraman (vishwanathj) wrote :
Revision history for this message
Sridhar Ramaswamy (srics-r) wrote :

The reason is similar to comments in,

https://bugs.launchpad.net/tacker/+bug/1475047

Changed in tacker:
importance: Undecided → Wishlist
Revision history for this message
Sridhar Ramaswamy (srics-r) wrote :

Moving it back to our backlog based on the discussion in,

https://review.openstack.org/#/c/203371

Changed in tacker:
importance: Wishlist → Low
Changed in tacker:
assignee: nobody → Bob Haddleton (bob-haddleton)
status: New → In Progress
tags: added: tacker-server
removed: tacker
Sripriya (sseetha)
summary: - Create VNF from Horizon and tackerclient allows to create VNFs with
- duplicate names
+ Create VNF, VNFD and VIM from Horizon and tackerclient allows to create
+ resosurces with duplicate names
description: updated
Sripriya (sseetha)
Changed in tacker:
assignee: Bob Haddleton (bob-haddleton) → Sripriya (sseetha)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tacker (master)

Fix proposed to branch: master
Review: https://review.openstack.org/329759

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tacker (master)

Reviewed: https://review.openstack.org/329759
Committed: https://git.openstack.org/cgit/openstack/tacker/commit/?id=f9729fb388b06672bdd05388d1d8047fb45abfaa
Submitter: Jenkins
Branch: master

commit f9729fb388b06672bdd05388d1d8047fb45abfaa
Author: Sripriya <email address hidden>
Date: Tue Jun 14 21:36:54 2016 -0700

    Introduce uniqueness constraint on resource names

    Resource names are handled to be unique per tenant for all 3
    resources vnfd, vnf and vim.

    Also existing duplicate names are updated to name-<12char. uudid>
    based on resource id's last 12 char. to handle the uniqueness
    constraint on 'name' column for all 3 resources.

    Change-Id: I689d7219db67892b855e1dc5c3698f9e1a67b408
    Closes-Bug: #1475047
    Closes-Bug: #1474993

Changed in tacker:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tacker 0.5.0

This issue was fixed in the openstack/tacker 0.5.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tacker (master)

Change abandoned by Bob Haddleton (<email address hidden>) on branch: master
Review: https://review.openstack.org/211207

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.