Comment 7 for bug 805210

Revision history for this message
Philipp C. Heckel (binwiederhier) wrote : Re: [Bug 805210] Re: putting a larger file in synced folder generates large amount of Watcher events

I figured that out already -- I forgot the increment i++
Are you by any change related to Edsger Dijkstra?

On Wed, Jul 6, 2011 at 10:53 PM, Bjorge Dijkstra <email address hidden> wrote:
> I don't think it will be much of a problem that you walk again through
> the list. Since you now prevent the queue from filling up with a lot of
> duplicates the queue will in general be quite short (unless a lot
> different files change at the same time).
>
> In its current form it will probably hang though, since the while loop
> will only terminate if you remove all events from the queue which is not
> very likely to happen.
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/805210
>
> Title:
>  putting a larger file in synced folder generates large amount of
>  Watcher events
>
> Status in Syncany:
>  Confirmed
>
> Bug description:
>  When I copy a somewhat larger file (e.g. a couple of megabytes) into
>  the synchronized folder then this generates a very large amount of
>  file watcher events and corresponding indexer updates.
>
>  11-07-03 20:39:24 | vulcan     | BufferedWatcher      | BufWatchTimer      | INFO     : ENTRY_CREATE /home/bjd/Public/CIMG2015.JPG
>  11-07-03 20:39:24 | vulcan     | LocalWatcher         | BufWatchTimer      | INFO     : Watcher: Checking new/modified file /home/bjd/Public/CIMG2015.JPG
>  11-07-03 20:39:24 | vulcan     | LocalWatcher         | BufWatchTimer      | INFO     : Watcher: Checking new/modified file /home/bjd/Public/CIMG2015.JPG
>  11-07-03 20:39:24 | vulcan     | Indexer              | Indexer            | INFO     : Processing request org.syncany.index.requests.CheckIndexRequest@746ac18c
>  11-07-03 20:39:24 | vulcan     | LocalWatcher         | BufWatchTimer      | INFO     : Watcher: Checking new/modified file /home/bjd/Public/CIMG2015.JPG
>  11-07-03 20:39:24 | vulcan     | CheckIndexRequest    | Indexer            | INFO     : Indexer: Checking file /home/bjd/Public/CIMG2015.JPG ...
>  11-07-03 20:39:24 | vulcan     | LocalWatcher         | BufWatchTimer      | INFO     : Watcher: Checking new/modified file /home/bjd/Public/CIMG2015.JPG
>  11-07-03 20:39:24 | vulcan     | LocalWatcher         | BufWatchTimer      | INFO     : Watcher: Checking new/modified file /home/bjd/Public/CIMG2015.JPG
>  11-07-03 20:39:24 | vulcan     | LocalWatcher         | BufWatchTimer      | INFO     : Watcher: Checking new/modified file /home/bjd/Public/CIMG2015.JPG
>  ... <repeated lots of times> ...
>
>  11-07-03 20:39:25 | vulcan     | Indexer              | Indexer            | INFO     : Processing request org.syncany.index.requests.CheckIndexRequest@51d7aa64
>  11-07-03 20:39:25 | vulcan     | CheckIndexRequest    | Indexer            | INFO     : Indexer: Checking file /home/bjd/Public/CIMG2015.JPG ...
>  11-07-03 20:39:25 | vulcan     | CheckIndexRequest    | Indexer            | INFO     : File found in DB. Same modified date, same size. Nothing to do!
>  11-07-03 20:39:25 | vulcan     | CheckIndexRequest    | Indexer            | INFO     : Checking file DONE: /home/bjd/Public/CIMG2015.JPG
>  11-07-03 20:39:25 | vulcan     | Indexer              | Indexer            | INFO     : Processing request org.syncany.index.requests.CheckIndexRequest@6d172f8f
>  11-07-03 20:39:25 | vulcan     | CheckIndexRequest    | Indexer            | INFO     : Indexer: Checking file /home/bjd/Public/CIMG2015.JPG ...
>  11-07-03 20:39:25 | vulcan     | CheckIndexRequest    | Indexer            | INFO     : File found in DB. Same modified date, same size. Nothing to do!
>  11-07-03 20:39:25 | vulcan     | CheckIndexRequest    | Indexer            | INFO     : Checking file DONE: /home/bjd/Public/CIMG2015.JPG
>  11-07-03 20:39:25 | vulcan     | Indexer              | Indexer            | INFO     : Processing request org.syncany.index.requests.CheckIndexRequest@34ae19a
>  ... <repeated lots of times> ...
>
>  Moving parentKey.reset() from the BufferedWatcher worker thread to the
>  end of processEvent() to hold of any new events until after processing
>  seems to solve this (see attached patch).
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/syncany/+bug/805210/+subscriptions
>