Comment 7 for bug 1624176

Revision history for this message
Kota Tsuyuzaki (tsuyuzaki-kota) wrote :

Hi, Clay. I figured out this problem has been resolved with https://review.openstack.org/#/c/215276 on the newest master. (my change suggested at comment #5 is not necessary though)

Current master has already had the unit tests such a duplicated fragment indexes on GET objects. Exactly, before the patch 215276 landed, the duplicated fragments will cause a 500 Internal Server error. I figured out it with [2]. The procedure is 1. remove change, 2. apply the test[1] 3.run the test. exactly that failed. However, the same test is now success on the master so that no matter exists on upstream swift, IMO.

Hence, I'd like to make this fix committed or invalid stats (maybe fix committed is better?) but until Clay confirmed that, I changes the stats to "incomplete" right now.

1: https://github.com/openstack/swift/blob/master/test/unit/proxy/controllers/test_obj.py#L2670
2: https://gist.github.com/bloodeagle40234/1645bc22703e335eab61529f700e4b17