Reviewed: https://review.openstack.org/78542 Committed: https://git.openstack.org/cgit/openstack/python-glanceclient/commit/?id=ab5c5b5d7c214b17b48add9caeaa36a81e3886f5 Submitter: Jenkins Branch: master
commit ab5c5b5d7c214b17b48add9caeaa36a81e3886f5 Author: wanghong <email address hidden> Date: Thu Mar 6 16:18:39 2014 +0800
Change assertTrue(isinstance()) by optimal assert
assertTrue(isinstance(A, B)) or assertEqual(type(A), B) in tests should be replaced by assertIsInstance(A, B) provided by testtools.
I have searched all the tests, there is only one wrong usage.
Change-Id: Ib1db1a2dca7b5d8cbfe823973e4b571d0f0925c5 Closes-bug: #1268480
Reviewed: https:/ /review. openstack. org/78542 /git.openstack. org/cgit/ openstack/ python- glanceclient/ commit/ ?id=ab5c5b5d7c2 14b17b48add9cae aa36a81e3886f5
Committed: https:/
Submitter: Jenkins
Branch: master
commit ab5c5b5d7c214b1 7b48add9caeaa36 a81e3886f5
Author: wanghong <email address hidden>
Date: Thu Mar 6 16:18:39 2014 +0800
Change assertTrue( isinstance( )) by optimal assert
assertTrue( isinstance( A, B)) or assertEqual( type(A) , B) in tests
should be replaced by assertIsInstance(A, B) provided by testtools.
I have searched all the tests, there is only one wrong usage.
Change-Id: Ib1db1a2dca7b5d 8cbfe823973e4b5 71d0f0925c5
Closes-bug: #1268480