Comment 5 for bug 1095730

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to swift (master)

Reviewed: https://review.openstack.org/21553
Committed: http://github.com/openstack/swift/commit/2267b030bfe5921f0cdde2facff284b4ceba3839
Submitter: Jenkins
Branch: master

commit 2267b030bfe5921f0cdde2facff284b4ceba3839
Author: Tong Li <email address hidden>
Date: Wed Feb 13 13:54:51 2013 -0500

    Swift MemcacheRing (set) interface is incompatible fixes

    This patch fixes the Swift MemcacheRing set and set_multi
    interface incompatible problem with python memcache. The fix
    added two extra named parameters to both set and set_multi
    method. When only time or timeout parameter is present, then one
    of the value will be used. When both time and timeout are present,
    the time parameter will be used.

    Named parameter min_compress_len is added for pure compatibility
    purposes. The current implementation ignores this parameter.

    To make swift memcached methods all consistent cross the board,
    method incr and decr have also been changed to include a new
    named parameter time.

    In future OpenStack releases, the named parameter timeout will be
    removed, keep the named parameter timeout around for now is
    to make sure that mismatched releases between client and server
    will still work.

    From now on, when a call is made to set, set_multi, decr, incr
    by using timeout parametner, a warning message will be logged to
    indicate the deprecation of the parameter.

    Fixes: bug #1095730
    Change-Id: I07af784a54d7d79395fc3265e74145f92f38a893