Comment 4 for bug 786156

21.05.2011 19:40, Jelmer Vernooij пишет:
>> #ifndef _MSC_VER
>> #pragma GCC ...
>> #endif

> I'm happy for these to be warnings, and I think they *should* warnings
> on systems where we can't hide those symbols until we find an
> alternative solution.

Jelmer, MSVC *by default* hides symbols and don't export them from
dll. That was always my frustration with GCC that it by default export
everything from shared libraries. Thank you for pointing me to the
appropriate pragmas, I'll use it in my code now.

But I think my patch is correct, see
http://gcc.gnu.org/wiki/Visibility and section about Windows
compatibiltiy.

>> Also there are warnings about type conversions, perhaps implicit
>> conversions, and possible loss of data:
>>
>> subvertpy\util.c(635) : warning C4244: функция: преобразование 'const svn_filesize_t' в 'long', возможна потеря данных
>> subvertpy\util.c(650) : warning C4244: функция: преобразование 'const apr_time_t' в 'long', возможна потеря данных
>>
>> subvertpy\repos.c(688) : warning C4244: функция: преобразование
>> 'svn_filesize_t' в 'long', возможна потеря данных
>>
>> You may want to check that and maybe provide and explicit cast.
> I don't speak Russian very well, and I don't have MSVC here. Can you
> parahprase what the errors are about?

http://msdn.microsoft.com/en-us/library/th7a07tz(v=vs.80).aspx

I'm sorry about Russian warnings, I'm going to uninstall Russian
MSVC2008 and install English one instead.

--
All the dude wanted was his rug back