Comment 14 for bug 1766980

Revision history for this message
Ryan Harper (raharper) wrote : Re: [Bug 1766980] Re: Failed to import ssh key

On Thu, Apr 26, 2018 at 12:40 PM, Steve Langasek
<email address hidden> wrote:
>> That means that network-online won't wait for the network to be up,
>> and cloud-config/cloud-final run after network is online since many
>> operations do use networking.
>
> That is not the agreed meaning of network-online. network-online should
> only be true if at least one interface, and a default route, and DNS,
> are available; and only after all non-optional interfaces are up or
> timed out. In the case where you only have one interface at install
> time, 'optional' should make no difference (and if it does, that needs
> to be fixed elsewhere still).

Are you suggesting that for a system with only one interface and that
it's marked optional networkd-wait-online should wait for it?

> In the case where you have more than one interface, there's a design
> question of whether we should default to waiting for all interfaces to be up.

I'm certainly not asking for all interfaces to be up; We're in
violent agreement that at least *one* should be up.
In this bug, there was only one, *and* it was marked optional.

>
> So I'm ok with us changing subiquity to make the interfaces not-optional
> on install as that seems to be the more robust solution.

I think whatever the user accepts or configures should NOT include optional.
That's sufficient to resolve this bug.

If there are additional nics that don't get configured in subiquity ui, those
could either stay unconfigured, or marked optional. We may want to include
them as optional in the config to communicate that the installer saw the
interfaces but the user chose not to configure it.

That's likely out of scope for this bug, but worth discussing long term.

>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1766980
>
> Title:
> Failed to import ssh key
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/subiquity/+bug/1766980/+subscriptions