I strongly disagree with displaying this. It seems extremely clunky: why display addresses and then mention they are wrong? Plus it's not impossible that the setup is done "on purpose", and that the users have configured their host appropriately to access the system with whatever access is provided, even with user-mode networking.
Rather than doing this, I would support either doing better detection that permits us to make sure the IP addresses would be wrong (which seems fraught with peril too), or leave it to users to know what they are doing.
An elegant solution might be to always display the ssh line for user@hostname, and expect that users will pick that first, or display user@hostname, and list "configured IP addresses" after that (without the ssh line), so that if access via the hostname doesn't work, then one of the IPs might.
I strongly disagree with displaying this. It seems extremely clunky: why display addresses and then mention they are wrong? Plus it's not impossible that the setup is done "on purpose", and that the users have configured their host appropriately to access the system with whatever access is provided, even with user-mode networking.
Rather than doing this, I would support either doing better detection that permits us to make sure the IP addresses would be wrong (which seems fraught with peril too), or leave it to users to know what they are doing.
An elegant solution might be to always display the ssh line for user@hostname, and expect that users will pick that first, or display user@hostname, and list "configured IP addresses" after that (without the ssh line), so that if access via the hostname doesn't work, then one of the IPs might.