Comment 18 for bug 306589

Revision history for this message
Emilien Klein (emilien-klein) wrote :

The original patch (by Ludovic) that got applied does not fix the core of the problem, which is cause by calling .decode() on that string. On my French system:

>>> print sys.getfilesystemencoding()
UTF-8

So replacing decode('utf8') by decode(sys.getfilesystemencoding()) doesn't do anything useful.

I've attached a new patch to bug #913453 that removes the whole decode() part, and now subtitles can be properly downloaded to folders containing accents. When the patch is applied, both issues can be closed.